From 6933f2871ea4ee188b0772ccc7e488ad4f4338de Mon Sep 17 00:00:00 2001 From: Chris Li <76067158+666lcz@users.noreply.github.com> Date: Fri, 8 Jul 2022 11:09:14 -0700 Subject: [PATCH] Explorer: Fix off by 1 error in pagination (#3100) --- .../src/components/transaction-card/RecentTxCard.tsx | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/explorer/client/src/components/transaction-card/RecentTxCard.tsx b/explorer/client/src/components/transaction-card/RecentTxCard.tsx index c5a2de68adb15..0c1bf7795387d 100644 --- a/explorer/client/src/components/transaction-card/RecentTxCard.tsx +++ b/explorer/client/src/components/transaction-card/RecentTxCard.tsx @@ -53,11 +53,8 @@ function generateStartEndRange( ): { startGatewayTxSeqNumber: number; endGatewayTxSeqNumber: number } { // Pagination pageNum from query params - default to 0; No negative values const txPaged = pageNum && pageNum > 0 ? pageNum - 1 : 0; - const endGatewayTxSeqNumber: number = txCount - txNum * txPaged; - const tempStartGatewayTxSeqNumber: number = endGatewayTxSeqNumber - txNum; - // If startGatewayTxSeqNumber is less than 0, then set it 1 the first transaction sequence number - const startGatewayTxSeqNumber: number = - tempStartGatewayTxSeqNumber > 0 ? tempStartGatewayTxSeqNumber : 1; + const endGatewayTxSeqNumber = txCount - txNum * txPaged; + const startGatewayTxSeqNumber = Math.max(endGatewayTxSeqNumber - txNum, 0); return { startGatewayTxSeqNumber, endGatewayTxSeqNumber,