Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partners - FE/BE - Region and Neighborhood #4596

Open
emilyjablonski opened this issue Jan 22, 2025 · 5 comments
Open

Partners - FE/BE - Region and Neighborhood #4596

emilyjablonski opened this issue Jan 22, 2025 · 5 comments
Assignees

Comments

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Jan 22, 2025

These two fields (Region and Neighborhood) exist in the partners site and display to the right of building address:
Screenshot 2025-02-11 at 10.03.34 AM.png

We need to add the "Region" and the "Neighborhood" fields to the address section.

Note: this solution will only work for Detroit Regions and neighborhoods. We will follow-up later with a more dynamic option

Steps needed for Region:

Create a new feature flag for this feature enableRegions

  • Backend:
    • Add "region" to the listing.dto.ts
      • Value of the RegionEnum. Make sure this is exposed in the swagger doc
    • Update listing create endpoint to save the region when it exists in the dto
    • Update listing edit endpoint to save the region when it exists in the dto
    • Update/verify that the listing get endpoints returns the "region" field
    • Add the "region" field to the CSV export
      • The column should only exist if the feature flag is turned on at least one jurisdiction user has access to
  • Frontend:
    • Add the new field in the "Building Address " section to the right of the zipcode
      • This should be behind the new feature flag
      • When it shows, the "Year Built" field will get moved to the next line
      • The list of options can use the DB RegionEnum exposed in the swagger doc

Steps needed for Neighborhood:

Currently in Core, we do already have a Neighborhood field that is an open text input. However, in Detroit this field is a drop down with limited specific inputs that are used to filter in Detroit.

  • Backend:
    • No changes are needed for this ticket
  • Frontend:
  • When the above feature flag is set to true for the jurisdiction change the "neighborhood" field from an input to a drop down
    • Values for the dropdown can be hardcoded for now in the partner site similar to how Detroit does it
    • If the value of the "neighborhood" select is changed, the "region" should also change to the mapped region
    • If the value of the "region" is change the "neighborhood" value should clear

AC:

In core:

  • With the region toggle on, partner users can enter a region on a listing.
  • With the region toggle on, partner users can select a neighborhood from a pre-created list
  • With the region toggle on, if a partner user changes the "neighborhood" the "region" changes to the corresponding region
  • With the region toggle on, if a partner user changes the "region" the "neighborhood" entry clears
  • With the region toggle off, partner users can enter any neighborhood into the field
  • A listing with a neighborhood and region will show up in the listing csv export
@emilyjablonski
Copy link
Collaborator Author

emilyjablonski commented Jan 22, 2025

@ludtkemorgan Noticed this one was missing - want to make sure we do intend to bring it over! If not I can close. I'm not sure how we would handle the typing as it is an enum now

@emilyjablonski emilyjablonski changed the title Partners - FE/BE - Region FE/BE - Region Jan 22, 2025
@emilyjablonski emilyjablonski changed the title FE/BE - Region Partners - FE/BE - Region Jan 22, 2025
@ludtkemorgan
Copy link
Collaborator

@emilyjablonski nice catch. Looks like I missed this. I think we need to have a mini spike to see how we can handle the enums as the long term solution they shouldn't be hardcoded. I'll create a subtask for that

@sarahlazarich
Copy link
Collaborator

@emilyjablonski do we need designs for this, or would this be ready to pull in?

@sarahlazarich sarahlazarich changed the title Partners - FE/BE - Region Partners - FE/BE - Region and Neighborhood Feb 10, 2025
@sarahlazarich
Copy link
Collaborator

Question for @emilyjablonski and @eajensenwa :

  • Will we ever need to show the application date into in the right rail?

@emilyjablonski
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants