Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile performs destructive system updates (editing dotfiles, installing JRE) #47

Open
iainmerrick opened this issue Dec 15, 2021 · 0 comments
Open

Makefile performs destructive system updates (editing dotfiles, installing JRE) #47

iainmerrick opened this issue Dec 15, 2021 · 0 comments

Comments

@iainmerrick
Copy link

The Linux installation instructions on the website (https://openapi.bow-swift.io/docs/quick-start/installation-guide/#-linux-users) ask you to sudo make linux. Mac users may be tempted to build from the Makefile as well as the Homebrew installation doesn't currently work (#41).

The linux target breaks normal conventions and does a bunch of destructive updates:

  • It both builds and installs (usually make install is a separate step)
  • It creates system installation directories before building, not after
  • It installs system-wide openjdk-8-jre-headless
  • It installs bash and zsh code completions

Installing dependencies, building the code and installing the code should be separate targets.

It should be possible to both build the code and execute it locally without using sudo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iainmerrick