Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style sheet URL is broken #42

Closed
GaryJones opened this issue Apr 17, 2014 · 4 comments
Closed

Style sheet URL is broken #42

GaryJones opened this issue Apr 17, 2014 · 4 comments
Assignees
Milestone

Comments

@GaryJones
Copy link
Collaborator

GitHub is now including the full URL to the style sheet in their JSON response, so the resolved URL is https://gist.github.comhttp://gist.github.com... which breaks the appearance of gists.

@GaryJones GaryJones added the bug label Apr 17, 2014
@GaryJones GaryJones self-assigned this Apr 17, 2014
@GaryJones GaryJones added this to the 2.0.3 milestone Apr 17, 2014
@GaryJones
Copy link
Collaborator Author

If I'm reading it right, a user can update any post containing a gist, and that will trigger the cache to be cleared for that post, and it should end with the global style sheet option being updated with the new value.

@bradyvercher - I created a hotfix/2.0.3 branch so this could be released without including the new bookmark URL feature. Once tagged, it will need to be merged into master (as latest stable release) and into develop (for ongoing work). "Tested up to" could also be updated.

@carldanley
Copy link

I too have experienced the same breakage. When can we get this into the plugin? It's breaking my site at the moment.

@carldanley
Copy link

Also - FWIW, @GaryJones's patch does resolve the broken stylesheet URL. 👍

@bradyvercher
Copy link
Owner

Patch worked for me, too, so I pushed this as 2.0.3. Thanks for the fix @GaryJones!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants