Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check how gists look on AMP pages #69

Closed
GaryJones opened this issue Oct 19, 2016 · 3 comments
Closed

Check how gists look on AMP pages #69

GaryJones opened this issue Oct 19, 2016 · 3 comments
Labels
Status: Investigation Needed

Comments

@GaryJones
Copy link
Collaborator

AMP pages use a limited set of HTML elements, and strip everything else out.

Expected Behaviour

Ideally, if the gist can't be displayed correctly, we'd just leave a clear link to the exact gist ID, file and line number as needed.

Current Behavior

No idea - but it should be tested.

Possible Solution

I'm really not even sure how we'd test if the current page is being shown in an AMP context.
@GaryJones
Copy link
Collaborator Author

https://github.com/Automattic/amp-wp#handling-media

Looks like there might be some custom embed handler we could use, that would allow at least something to be displayed, instead of it getting stripped out completely.

@anythinggraphic
Copy link

Awesome!!

@GaryJones
Copy link
Collaborator Author

There is now an amp-gist component.

@GaryJones GaryJones closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Investigation Needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GaryJones @anythinggraphic