Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double vertical scrolling bar #6

Open
atais opened this issue Aug 22, 2015 · 14 comments
Open

Double vertical scrolling bar #6

atais opened this issue Aug 22, 2015 · 14 comments

Comments

@atais
Copy link
Contributor

atais commented Aug 22, 2015

Hello.

I have experienced a small bug in the CSS.
zrzut ekranu 2015-08-22 o 23 56 28

I have managed to solve it easily by adding:

  body{
    overflow-y: hidden;
  }

Overflow on the page ribbon did not fix it for me.

@braginteractive
Copy link
Owner

Do you see the double vertical scrollbar on our demo ribbon page? http://mdlwp.com/demo/ribbon-page/

@atais
Copy link
Contributor Author

atais commented Aug 23, 2015

Hm, no it's ok in the demo. I will try to find what is causing the issue.

@atais
Copy link
Contributor Author

atais commented Aug 23, 2015

It is doubled when you log in to Wordpress and the Wordpress bar is visible.

@braginteractive
Copy link
Owner

I think because they are both fixed.

@atais
Copy link
Contributor Author

atais commented Aug 26, 2015

you can change some div's to have overflow-y: hidden;. I will do some fixes and PR when I finish my fork.

@braginteractive
Copy link
Owner

@leoradmagnegithub does the demo have a double scrollbar?

@ghost
Copy link

ghost commented Apr 23, 2016

My website work perfectly on every browser, except for Mozilla Firefox (v.45.0.1).
This because there's a double vertical scroll bar.
This bar isn't in all other browsers like Chrome, Opera and IE 11.

In the demo, this double vertical scroll bar never appear.

cattura

@alexandre67fr
Copy link

The double bar appears when administrators are logged in.

This is due to the fact that WP adds

html { margin-top: 32px !important; }

The first scroll bar appears for html tag, the second one for div.mdl-layout

A solution simple solution for modern browsers in functions.php:

// Bugfix for double admin bar

add_action( 'wp_head', function () {

  if ( ! is_admin_bar_showing() )
    return;

  echo '
    <style>
      html {
        overflow: hidden;
      }
      .mdl-layout {
        height: calc(100% - 32px);
      }
      @media screen and (max-width: 782px) {
        .mdl-layout {
          height: calc(100% - 46px);
        }
      }
    </style>
  ';    

}, 999);

@alexandre67fr
Copy link

@leoradmagnegithub my comment is a reply to @atais 's issue, which is double vertical bar on ribbon template, when logged in as administrator in all browsers.

The issue that you've posted is most probably a different one.

@ghost
Copy link

ghost commented Jun 2, 2016

Ah ok, sorry.
Have you got any idea about my issue?

@alexandre67fr
Copy link

No, sorry. I didn't see any issues with my website using the latest version of the theme in Firefox.
Is your site online? I could have a look, and see what might be the issue.

@alexandre67fr
Copy link

You're using a plugin that adds a bar at the top of the page. This not an issue of the theme.

@alexandre67fr
Copy link

You need help of a developer with your website, this is not an issue if this theme.

@leoradprogrammer
Copy link

Yes, sorry for the loss of time. I had had a problem on my site.

(This is the new account of the "ghost" in the previous comments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants