Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options being passed to the ollama chat api #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alappe
Copy link
Contributor

@alappe alappe commented Sep 17, 2024

I noticed that https://github.com/ollama/ollama/blob/main/docs/api.md#generate-a-chat-completion and https://github.com/ollama/ollama/blob/main/docs/modelfile.md#valid-parameters-and-values document that those options all need to be passed to the options: {} sub structure.

My local instance testing with llama v3.1 and ollama v0.3.10 complains because num_gqa is unknown. I left it in there for now because other models might need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant