Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing UI for failed swap #1306

Open
MarnixCroes opened this issue Aug 7, 2024 · 3 comments
Open

missing UI for failed swap #1306

MarnixCroes opened this issue Aug 7, 2024 · 3 comments

Comments

@MarnixCroes
Copy link
Contributor

General Description

There is no user feedback in the case that a swap fails.

How To Reproduce?

  1. Go to Receive
  2. Click on Receive via BTC address
  3. swap fails
  4. there is no way for the user to know that it failed, he assumes he got rugpulled as balance doesn't get updated

only after 288 blocks user sees the option for refund and knows that the swap failed

Breez Version

0.17

@kingonly
Copy link
Member

kingonly commented Aug 7, 2024

That's not accurate. It depends on the reason of the failure. If the swap is under or over the limit, there's an indication in a form of a warning icon. If we keep trying to swap, we don't show an error because there's a chance the swap will succeed. Do you know what caused your swap to fail?

@MarnixCroes
Copy link
Contributor Author

That's not accurate. It depends on the reason of the failure. If the swap is under or over the limit, there's an indication in a form of a warning icon. If we keep trying to swap, we don't show an error because there's a chance the swap will succeed. Do you know what caused your swap to fail?

ok.
@JssDWt figured it out: the max possible receive amount for not opening a new channel doesn't take into account the extra commitment fee for a htlc. (a bug that is/was going to be fixed)
please correct me if I'm wrong.

@JssDWt
Copy link
Contributor

JssDWt commented Aug 7, 2024

@JssDWt figured it out: the max possible receive amount for not opening a new channel doesn't take into account the extra commitment fee for a htlc. (a bug that is/was going to be fixed)\nplease correct me if I'm wrong.

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants