Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive limit in "Create an Invoice" should account for any pending deposits #179

Open
whitslack opened this issue Sep 25, 2019 · 1 comment

Comments

@whitslack
Copy link

  1. Start with a new installation of Breez Mobile.
  2. Choose to "Add Funds" by depositing to a Bitcoin address. Note that the displayed deposit limit is over 900 ksat. Send a deposit of 500 ksat.
  3. Before the deposit transaction confirms, choose to "Create an Invoice." Note that the displayed receive limit is over 900 ksat. Create an invoice for 500 ksat.
  4. Pay the invoice from another Lightning wallet.
  5. When the deposit eventually confirms some time later, there will be insufficient remaining incoming channel capacity for Breez to pay the funds into the user's Lightning wallet, thus raising this warning message:

    On-chain Transaction
    Breez was not able to transfer the funds to your balance since the executed transaction was above the specified limit. You will be able to redeem your funds after block NNNNNN (~48 hours).

Suggested improvement is to account for any pending deposit in the receive limit shown on the "Create an Invoice" screen. In the above example, the displayed receive limit in step 3 should have had the pending 500-ksat deposit deducted from it.

@kingonly
Copy link
Member

Great suggestion 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants