Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

ScoreSaber: Oculus version of DLL is downloaded instead of Steam version #6

Closed
n3tman opened this issue Apr 6, 2019 · 3 comments
Closed
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@n3tman
Copy link

n3tman commented Apr 6, 2019

Not sure if there are any built-in checks to download the right version, but I'm on Steam an I got the Oculus DLL (321,536 bytes) instead of Steam DLL (313,856 bytes).

This produces an error and scores don't work:

[ERROR @ 22:36:31 | IPA/Loader] Could not load ScoreSaber.dll! System.Reflection.ReflectionTypeLoadException: Exception of type 'System.Reflection.ReflectionTypeLoadException' was thrown.
[ERROR @ 22:36:31 | IPA/Loader]   at (wrapper managed-to-native) System.Reflection.Assembly.GetTypes(System.Reflection.Assembly,bool)
[ERROR @ 22:36:31 | IPA/Loader]   at System.Reflection.Assembly.GetTypes () [0x00000] in <d7ac571ca2d04b2f981d0d886fa067cf>:0
[ERROR @ 22:36:31 | IPA/Loader]   at IPA.Loader.PluginManager.LoadPluginsFromFile (System.String file) [0x00043] in <9def8fd80d414c4a888f7fa70ee68951>:0

Manual install of the right DLL fixes the problem. But I see people already report it, so I guess it's better to fix it.

@megalon
Copy link
Member

megalon commented Apr 6, 2019

I'll take a look at this, I think I might know what's causing it. Thanks

@megalon megalon self-assigned this Apr 6, 2019
@megalon megalon added the bug Something isn't working label Apr 6, 2019
@megalon megalon closed this as completed in #8 Apr 6, 2019
@megalon megalon reopened this Apr 9, 2019
@megalon
Copy link
Member

megalon commented Apr 9, 2019

Apparently this is still happening.

@megalon megalon added the help wanted Extra attention is needed label Apr 9, 2019
@megalon
Copy link
Member

megalon commented Apr 9, 2019

Here is the relevant code section if anyone is interested in trying to figure out why this is still happening.

I'm wondering if sometimes the API doesn't return both files, so it defaults to assuming there is only one file, and thus installing the Steam version.

https://github.com/beat-saber-modding-group/BeatSaberModInstaller/blob/5c499273b3555a17df6d572847e23f40321a72a2/BeatSaberModManager/Core/RemoteLogic.cs#L81-L114

@megalon megalon pinned this issue Apr 9, 2019
@n3tman n3tman closed this as completed Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants