Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for connect only + listening #10

Closed
davecgh opened this issue Oct 4, 2013 · 2 comments
Closed

Support for connect only + listening #10

davecgh opened this issue Oct 4, 2013 · 2 comments

Comments

@davecgh
Copy link
Member

davecgh commented Oct 4, 2013

The current approach of connect where you only connect to the specified peers also disables listening.

This make sense for most use cases, however there is also the case where a user might want to connect only to specific peers as well as listen while controlling the access via their firewall.

One such scenario is a user could setup a tor hidden service while still only connecting to trusted nodes.

Suggested by todd

@toddfries
Copy link
Contributor

Glancing at the code, it would add a lot of complexity to do something
other than the following simple change.

Users can then use nolisten= as they prefer, without connect= explicitly
setting it for them.

Separately I will test to see if config options are applied in order. If that
is the case, then one simply can list 'nolisten=0' after the last 'connect='
line.

--- a/config.go +++ b/config.go @@ -351,7 +351,6 @@ func loadConfig() (*config, []string, error) { // Connect means no seeding or listening. if len(cfg.ConnectPeers) > 0 { cfg.DisableDNSSeed = true - cfg.DisableListen = true }

@ghost ghost assigned davecgh and owainga Nov 12, 2013
@davecgh
Copy link
Member Author

davecgh commented Nov 14, 2013

This has been implemented via #33.

@davecgh davecgh closed this as completed Nov 14, 2013
davecgh pushed a commit to davecgh/btcd that referenced this issue Aug 16, 2017
jrick pushed a commit to jrick/btcd that referenced this issue Oct 12, 2017
This commit modifies the NewMerkleBlock function to return the matched
transaction indices instead of their hashes.  This is being done because
it is much easier for the caller to lookup the matched transactions from
the original passed block based on their transaction index within the
block versus their hashes.
zhenyuzhao-cb pushed a commit to zhenyuzhao-cb/btcd that referenced this issue Feb 20, 2023
kcalvinalvin added a commit to kcalvinalvin/btcd that referenced this issue Nov 29, 2024
kcalvinalvin added a commit to kcalvinalvin/btcd that referenced this issue Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants