Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a href=""> transforms to invalid hiccup [:a {:href }] #1

Open
dustingetz opened this issue Sep 30, 2019 · 3 comments
Open

<a href=""> transforms to invalid hiccup [:a {:href }] #1

dustingetz opened this issue Sep 30, 2019 · 3 comments

Comments

@dustingetz
Copy link

Test case, line 10 of result is broken

<div class="cont">
  <div class="page-head">
    <h1>lightgallery <span class="version">V0.0.1</span></h1>
    <p class="lead">Full featured lightbox gallery. Zero dependencies.</p><a href="https://github.com/sachinchoolur/lightgallery.js" class="btn btn-primary btn-lg">View on github</a></div>

  <div class="demo-gallery">
    <ul id="lightgallery">
      <li data-responsive="https://sachinchoolur.github.io/lightgallery.js/static/img/1-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/1-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/1.jpg 800" data-src="https://sachinchoolur.github.io/lightgallery.js/static/img/1-1600.jpg"
      data-sub-html="<h4>Fading Light</h4><p>Classic view from Rigwood Jetty on Coniston Water an old archive shot similar to an old post but a little later on.</p>">
        <a href="">
          <img class="img-responsive" src="https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-1.jpg">
          <div class="demo-gallery-poster">
            <img src="https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png">
          </div>
        </a>
      </li>
      <li data-responsive="https://sachinchoolur.github.io/lightgallery.js/static/img/2-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/2-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/2.jpg 800" data-src="https://sachinchoolur.github.io/lightgallery.js/static/img/2-1600.jpg"
      data-sub-html="<h4>Bowness Bay</h4><p>A beautiful Sunrise this morning taken En-route to Keswick not one as planned but I'm extremely happy I was passing the right place at the right time....</p>">
        <a href="">
          <img class="img-responsive" src="https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-2.jpg">
          <div class="demo-gallery-poster">
            <img src="https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png">
          </div>
        </a>
      </li>
      <li data-responsive="https://sachinchoolur.github.io/lightgallery.js/static/img/13-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/13-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/13.jpg 800" data-src="https://sachinchoolur.github.io/lightgallery.js/static/img/13-1600.jpg"
      data-sub-html="<h4>Sunset Serenity</h4><p>A gorgeous Sunset tonight captured at Coniston Water....</p>">
        <a href="">
          <img class="img-responsive" src="https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-13.jpg">
          <div class="demo-gallery-poster">
            <img src="https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png">
          </div>
        </a>
      </li>
      <li data-responsive="https://sachinchoolur.github.io/lightgallery.js/static/img/4-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/4-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/4.jpg 800" data-src="https://sachinchoolur.github.io/lightgallery.js/static/img/4-1600.jpg"
      data-sub-html="<h4>Coniston Calmness</h4><p>Beautiful morning</p>">
        <a href="">
          <img class="img-responsive" src="https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-4.jpg">
          <div class="demo-gallery-poster">
            <img src="https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png">
          </div>
        </a>
      </li>
    </ul>
    <span class="small">Click on any of the images to see lightGallery</span>
  </div>
</div>
[:div {:class "cont"}
 [:div {:class "page-head"}
  [:h1 "lightgallery " 
   [:span {:class "version"} "V0.0.1"]]
  [:p {:class "lead"} "Full featured lightbox gallery. Zero dependencies."]
  [:a {:href "https://github.com/sachinchoolur/lightgallery.js", :class "btn btn-primary btn-lg"} "View on github"]]
 [:div {:class "demo-gallery"}
  [:ul {:id "lightgallery"}
   [:li {:data-responsive "https://sachinchoolur.github.io/lightgallery.js/static/img/1-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/1-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/1.jpg 800", :data-src "https://sachinchoolur.github.io/lightgallery.js/static/img/1-1600.jpg", :data-sub-html "<h4>Fading Light</h4><p>Classic view from Rigwood Jetty on Coniston Water an old archive shot similar to an old post but a little later on.</p>"}
    [:a {:href }
     [:img {:class "img-responsive", :src "https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-1.jpg"}]
     [:div {:class "demo-gallery-poster"}
      [:img {:src "https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png"}]]]]
   [:li {:data-responsive "https://sachinchoolur.github.io/lightgallery.js/static/img/2-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/2-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/2.jpg 800", :data-src "https://sachinchoolur.github.io/lightgallery.js/static/img/2-1600.jpg", :data-sub-html "<h4>Bowness Bay</h4><p>A beautiful Sunrise this morning taken En-route to Keswick not one as planned but I'm extremely happy I was passing the right place at the right time....</p>"}
    [:a {:href }
     [:img {:class "img-responsive", :src "https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-2.jpg"}]
     [:div {:class "demo-gallery-poster"}
      [:img {:src "https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png"}]]]]
   [:li {:data-responsive "https://sachinchoolur.github.io/lightgallery.js/static/img/13-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/13-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/13.jpg 800", :data-src "https://sachinchoolur.github.io/lightgallery.js/static/img/13-1600.jpg", :data-sub-html "<h4>Sunset Serenity</h4><p>A gorgeous Sunset tonight captured at Coniston Water....</p>"}
    [:a {:href }
     [:img {:class "img-responsive", :src "https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-13.jpg"}]
     [:div {:class "demo-gallery-poster"}
      [:img {:src "https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png"}]]]]
   [:li {:data-responsive "https://sachinchoolur.github.io/lightgallery.js/static/img/4-375.jpg 375, https://sachinchoolur.github.io/lightgallery.js/static/img/4-480.jpg 480, https://sachinchoolur.github.io/lightgallery.js/static/img/4.jpg 800", :data-src "https://sachinchoolur.github.io/lightgallery.js/static/img/4-1600.jpg", :data-sub-html "<h4>Coniston Calmness</h4><p>Beautiful morning</p>"}
    [:a {:href }
     [:img {:class "img-responsive", :src "https://sachinchoolur.github.io/lightgallery.js/static/img/thumb-4.jpg"}]
     [:div {:class "demo-gallery-poster"}
      [:img {:src "https://sachinchoolur.github.io/lightgallery.js/static/img/zoom.png"}]]]]]
  [:span {:class "small"} "Click on any of the images to see lightGallery"]]]
@dustingetz
Copy link
Author

Feel free to close, I'm just reporting the bug and moving on.

@phunanon
Copy link

I'm getting the same issue for HTML using boolean attributes like <button disabled>Test</button> -> [:button {:disabled } "Test"]

@mtnygard
Copy link

Similar problem with empty alt tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants