Channels Tags in sessionInfo #183
Comments
|
👍 I would love to formalize this. I 'tag' many different things (ripple chan, ref chan, etc, etc) just adding sessionInfo.* fields but that isn't the long term solution |
|
I’m not sure how to think about session info. Are we turning it into a legitimate metadata structure? Right now it’s a limited metadata structure - is the idea to really change that? Is if the right place to put this stuff. It doesn’t quite strike me as right but maybe I just need to reconceptualize sessioninfo. |
|
Maybe think of it as metadata for analysis.
… On May 26, 2018, at 6:16 AM, Brendon Watson ***@***.***> wrote:
I’m not sure how to think about session info. Are we turning it into a legitimate metadata structure? Right now it’s a limited metadata structure - is the idea to really change that? Is if the right place to put this stuff. It doesn’t quite strike me as right but maybe I just need to reconceptualize sessioninfo.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I’m basically fine w that. But I will say it’s like a weird slippery slope
in my mind. Like all metadata is useful for analysis - depending on the
depth of the analysis. So where to draw the line will be unclear. But it’s
prob fine for now. I think what it really is is that I want a more complete
metadata solution. I hate not gathering the data with a fully understood
metadata framework ahead of time.
On Sat, May 26, 2018 at 10:29 AM Dan Levenstein <[email protected]>
wrote:
… Maybe think of it as metadata for analysis.
> On May 26, 2018, at 6:16 AM, Brendon Watson ***@***.***>
wrote:
>
> I’m not sure how to think about session info. Are we turning it into a
legitimate metadata structure? Right now it’s a limited metadata structure
- is the idea to really change that? Is if the right place to put this
stuff. It doesn’t quite strike me as right but maybe I just need to
reconceptualize sessioninfo.
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTeEVnKzwjrMuqjQ1kvndkGAvx_0hks5t2Wa4gaJpZM4TeToV>
.
|
|
For, say ripple channel, I'm thinking of making a field in a field inside sessionInfo, like this: sessionInfo.LFPAnalysisChannels.RippleChannel. OK? |
|
How about sessionInfo.ChannelTags.RippleChannel? That way its more general than LFPAnalysis. I can add an easy way to add/edit ChannelTags in the sessionInfoGUI |
|
Although, wouldn't we want this metadata stored in the ripples.event file? as it pertains to channels used for that. I'm wondering how we can keep these things synchronized.. |
|
Yes definitely. Channels used for detection should always be stored in the relevant events.mat file or states.mat file or whatever it may be. Especially since you might have (for some unknown but maybe interesting physiological reason) two different ripple events on two different channels. (Maybe from two different regions? ;)) |
|
I’d like to have them somewhere BEFORE ripple detection so ripple detection
can look for it somewhere and use it.
SessionInfo isn’t my favorite but it’s ok.
Dan what about “TaggedChannels”?
…On Sun, Jun 3, 2018 at 12:34 PM Dan Levenstein ***@***.***> wrote:
Yes definitely. Channels used for detection should always we stored in the
events.mat file.
Especially since you might have (for some unknown but maybe interesting
physiological reason) two different ripple events on two different
channels. (Maybe from two different regions? ;))
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTW3MLSOgit0Oe1BKbu6OfF55NJoQks5t5BAMgaJpZM4TeToV>
.
|
|
@brendonw1, I agree having detectors inherit from sessionInfo is a great idea. We're getting closer and closer to OOP buzcode... |
|
@DavidTingley Good :) |
|
I'd prefer it be more general. A box for any channel tags you may have. for example, badchannels should move to sessionInfo.ChannelTags.badchannels |
|
I agree with that idea. It’s just that the term “channel tags” seems off to
me. Tags seems like the part that’s kind of informal and a term of the time
but not fully clear in meaning. I keep trying to think of ideas beyond what
I said but I can’t now. Any other ideas that seem right to you?
…On Mon, Jun 4, 2018 at 11:55 AM Dan Levenstein ***@***.***> wrote:
I'd prefer it be more general. A box for any channel tags you may have.
for example, badchannels should move to sessionInfo.ChannelTags.badchannels
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTf4Ekq28Rt3sXJpdD8EzAPCxTNkYks5t5VhhgaJpZM4TeToV>
.
|
|
I dunno, I thought the term tag was pretty standard/general - this is where you store any tags (labels) you want to associate with specific channels. Maybe that didn't get across or isn't how you're thinking about it? Seems like a good general feature to have. I don't really have another term for the same thing. ChannelLabels sounds clunky to me but could work I guess. |
|
I worry that it seems like a temporary term. But that might be because I’m old. I also think “coding” seems that way too :) Basically I’m fine with it if others are fine ... @DavidTingley - does “tag” seem like a solid term to use? If you’re fine I’m fine. |
|
The resounding silence on this issue convinces me that no one else cares and we should just do "channel tags" |
|
🦗🦗🦗
… On Jun 6, 2018, at 8:35 PM, Brendon Watson ***@***.***> wrote:
The resounding silence on this issue convinces me that no one else cares and we should just do "channel tags"
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
??? |
|
^^^crickets
… On Jun 6, 2018, at 8:41 PM, Brendon Watson ***@***.***> wrote:
???
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ah ;-P |
|
Oh, the crickets didn't look very crickety on here.... I guess github doesn't have good emoji integration. Here's a possible moving forward plan of attack:
|
|
Sounds perfect!
…On Fri, Jun 8, 2018 at 11:29 AM Dan Levenstein ***@***.***> wrote:
Oh, the crickets didn't look very crickety on here.... I guess github
doesn't have good emoji integration.
Here's a possible moving forward plan of attack:
1.
Update SessioninfoGUI to have a ChannelTags section
2.
make a dropdown list of common channel tags, and an option for the
user to add their own. users will select or enter a channel tag (i.e.
RippleChannel) and list the channels they want associated with that tag.
Will be saved as sessionInfo.ChannelTags.RippleChannel
3.
move badchannels to a common ChannelTag
4.
and to avoid issues with backwards compatibility of badchannels, make
bz_getSessionInfo move sessionInfo.badchannels to
sessionInfo.ChannelTags.badchannels if it finds them there when loading a
sessionInfo file
5.
Update existing functions that reference sesionInfo.badchannels to
reference sessionInfo.ChannelTags.badchannels
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#183 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADXrTaLBwojS5WXQx6hfXx5yGIJyR3koks5t6ph2gaJpZM4TeToV>
.
|
|
Step 1-3 is on my short time scale to-do list. Let me know if you dive into it first.
… On Jun 8, 2018, at 11:36 AM, Brendon Watson ***@***.***> wrote:
Sounds perfect!
On Fri, Jun 8, 2018 at 11:29 AM Dan Levenstein ***@***.***>
wrote:
> Oh, the crickets didn't look very crickety on here.... I guess github
> doesn't have good emoji integration.
>
> Here's a possible moving forward plan of attack:
>
> 1.
>
> Update SessioninfoGUI to have a ChannelTags section
> 2.
>
> make a dropdown list of common channel tags, and an option for the
> user to add their own. users will select or enter a channel tag (i.e.
> RippleChannel) and list the channels they want associated with that tag.
> Will be saved as sessionInfo.ChannelTags.RippleChannel
> 3.
>
> move badchannels to a common ChannelTag
> 4.
>
> and to avoid issues with backwards compatibility of badchannels, make
> bz_getSessionInfo move sessionInfo.badchannels to
> sessionInfo.ChannelTags.badchannels if it finds them there when loading a
> sessionInfo file
> 5.
>
> Update existing functions that reference sesionInfo.badchannels to
> reference sessionInfo.ChannelTags.badchannels
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#183 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADXrTaLBwojS5WXQx6hfXx5yGIJyR3koks5t6ph2gaJpZM4TeToV>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#183 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG7dmFtH9cgnKnZrc1e-F-25crMHW0f0ks5t6pn5gaJpZM4TeToV>.
|
|
Update on this: I've added the function bz_TagChannel(basePath,channums,tag) (see #294) The function is an easy way for the user to add "tags" to specific channels in the sessionInfo. It saves any tags in: sessionInfo.channelTags.(tagName) I haven't yet integrated into SessionInfoGUI (steps 1-2 above), but would like to do so, and move badchannels and all references to badchannels in the repo over to this form. (i.e. implement 3-5 above). Does anyone have a problem with this, or thoughts to improve documentation/implementation? |
add option to sessionInfoGUI to add arbitrary "tags" for channels.
For example: ThetaChannel, CTXRepresentativeChannel, etc etc.
Can even have drop-down menu for commonly used tags.
The text was updated successfully, but these errors were encountered: