Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Tag Data does not work as it should (?) #45

Open
caranha opened this issue Jun 6, 2023 · 1 comment
Open

Building Tag Data does not work as it should (?) #45

caranha opened this issue Jun 6, 2023 · 1 comment
Assignees

Comments

@caranha
Copy link
Owner

caranha commented Jun 6, 2023

There are some problems to solve regarding the building tag data file: config/map/tsukuba-tu-building-data.csv

  • First, if the file is not properly formatted (not enough tags? too many tags?) the simulator crashes with no clear error message.
  • Second, it is not clear that the behavior when there is not enough tag data is the desired behavior.

Desired behavior of the software:

  • Open Street Maps has tags for some (not all?) of the buildings.

  • These tags are used to indicate to the agents where they should go for several actions (agents are associated to residential areas, work at work tags appropriate for their jobs, go for leisure and groceries at appropriately tagged spots).

  • The simulator should check that the necessary tags exist, and raise warnings for unexpected tags

  • Sometimes, tags should be grouped (for example, for job groups)

  • Third: How the tags are processed and used should be better documented.

@caranha
Copy link
Owner Author

caranha commented Jun 13, 2023

Update:

The crash was pinpointed to a mismatch between tags required by workers (defined in professions.csv) and tags defined in the map (openstreetmaps tags and tags defined in tsukuba-tu-building-data).

So the solution for now is to match the worker tags and the map tags at loading time to check for missing tag maps, and warn the user the problem and possible solution (update the building map tag file).

Future issue: This might still leave problems with actions that are defined based on map data (example: move to hospital)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants