-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable returning stateful plaintext passports #45
Comments
Hmm... One thing you could do is park an NginX server in-front of your webpage and strip off any kwargs passed in? Alternatively do you think it would be better to have 2 separate URLS... or maybe a global system variable you can specify that turns this off when set (like an There is also the Thoughts? |
Hi @caronc - The use of a global variable such as |
I know it's been a very long time since I've looked at this, but I've finally had time to. But while doing it, i saw that there were quite a few flaws with the request and I wanted to bounce them off you to see if it was still worth changing up how we could handle this. First off; i think the problem here is the fact that anyone can change the URL
This would probably resolve #46 as well since you would no longer be able to update your configuration anymore with this shared global variable. Does this make sense? What are your thoughts? |
Just letting you know the last PR should solve all of your very valid issues you pointed out! 👍 |
❓ Question
The main apprise API webpage (https://github.com/caronc/apprise-api) contain the following text:
You can pass in attributes to the /json/urls/{KEY} such as privacy=1 which hides the passwords and secret tokens when returning the response.
The above does seem to hide the passwords returned but I couldn't find a way of actually stopping a user from calling /json/urls/{KEY} without the privacy=1 attribute? For example, is there a way in the apprise API {KEY} config to specify that passwords should always be returned to a GET /json/urls/{KEY} regardless of whether the privacy attribute is added or not?
The text was updated successfully, but these errors were encountered: