Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colors for variable.other.member #56

Open
NikitaRevenco opened this issue Dec 25, 2024 · 2 comments
Open

Change colors for variable.other.member #56

NikitaRevenco opened this issue Dec 25, 2024 · 2 comments

Comments

@NikitaRevenco
Copy link
Contributor

Imo there's a bit too much blue. Making variable.other.member the same colors as function is confusing. Having a different color for regular functions vs variables makes it easier to differentiate them. Could #50 be reverted? Just my suggestion. Feel free to close this

Before

image

After

image

@sgoudham
Copy link

sgoudham commented Dec 25, 2024

Struct members should be text iirc, seems like it's a side effect of #50

@uncenter
Copy link
Member

uncenter commented Dec 25, 2024

Struct members should be text iirc, seems like it's a side effect of #50

Correct. Helix doesn't differentiate between these, it's all the same variable.other.member. It boils down to an issue with the queries. I think changing this in the theme is worse, I would prefer if the upstream queries could be improved before we change things here again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants