Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PATCH method #42

Closed
erlingmat opened this issue Sep 5, 2012 · 15 comments
Closed

Implement PATCH method #42

erlingmat opened this issue Sep 5, 2012 · 15 comments
Assignees
Milestone

Comments

@erlingmat
Copy link

I would like to have the PATCH method implemented. So far, only clj-http implements the PATCH method that I need in my project. But it is bulky.

@neotyk
Copy link
Collaborator

neotyk commented Sep 5, 2012

Do you have some public server that supports PATCH method so I can test against it?

@erlingmat
Copy link
Author

Only if you have a salesforce.com account :/ our own servers do not support PATCH.

-----Original Message-----
From: Hubert Iwaniuk [mailto:[email protected]]
Sent: Wed 9/5/2012 11:27 AM
To: neotyk/http.async.client
Cc: Erling Matthiesen Møller
Subject: Re: [http.async.client] Implement PATCH method (#42)

Do you have some public server that supports PATCH method so I can test against it?


Reply to this email directly or view it on GitHub:
#42 (comment)

@neotyk
Copy link
Collaborator

neotyk commented Sep 5, 2012

Based on assumption that PATCH is like POST/PUT I will generate version for you this evening for testing.

@erlingmat
Copy link
Author

Cool. Thanks man.

Sendt fra min iPhone

Den 05/09/2012 kl. 13.09 skrev "Hubert Iwaniuk" [email protected]:

Based on assumption that PATCH is like POST/PUT I will generate version for you this evening for testing.


Reply to this email directly or view it on GitHub.

@neotyk
Copy link
Collaborator

neotyk commented Sep 5, 2012

I've pushed version that has PATCH method same as PUT/POST to clojars https://clojars.org/http.async.client/versions/0.5.0-SNAPSHOT

Please let me know if it works for you.

@ghost ghost assigned neotyk Sep 5, 2012
@erlingmat
Copy link
Author

I get this message when booting jetty
WARNING: promise already refers to: #'clojure.core/promise in namespace: http.async.client.request, being replaced by: #'http.async.client.util/promise
WARNING: promise already refers to: #'clojure.core/promise in namespace: http.async.client, being replaced by: #'http.async.client.util/promise

I did not get that message before upgrading to async client 0.5.0 snapshot.

-Erling

-----Original Message-----
From: Hubert Iwaniuk [mailto:[email protected]]
Sent: Wed 9/5/2012 6:26 PM
To: neotyk/http.async.client
Cc: Erling Matthiesen Møller
Subject: Re: [http.async.client] Implement PATCH method (#42)

I've pushed version that has PATCH method same as PUT/POST to clojars https://clojars.org/http.async.client/versions/0.5.0-SNAPSHOT

Please let me know if it works for you.


Reply to this email directly or view it on GitHub:
#42 (comment)

@neotyk
Copy link
Collaborator

neotyk commented Sep 10, 2012

Updated snapshot, please try again.

Apart from WARNING, did the PATCH method work?

@erlingmat
Copy link
Author

I did not get that far, the jetty never booted due to some other things :(

-Erling

-----Original Message-----
From: Hubert Iwaniuk [mailto:[email protected]]
Sent: Mon 9/10/2012 11:12 AM
To: neotyk/http.async.client
Cc: Erling Matthiesen Møller
Subject: Re: [http.async.client] Implement PATCH method (#42)

Updated snapshot, please try again.

Apart from WARNING, did the PATCH method work?


Reply to this email directly or view it on GitHub:
#42 (comment)

@neotyk
Copy link
Collaborator

neotyk commented Sep 20, 2012

Did it work with snapshot release?

@erlingmat
Copy link
Author

Yes thank you. My sunshine case worked Well.

-Erling

Sendt fra min iPhone

Den 20/09/2012 kl. 16.30 skrev "Hubert Iwaniuk" [email protected]:

Did it work with snapshot release?


Reply to this email directly or view it on GitHub.

@neotyk
Copy link
Collaborator

neotyk commented Sep 21, 2012

Glad to hear that!
Will bake a release soon.
Do you have any urgent need to for it not to be in snapshot?

@erlingmat
Copy link
Author

We would very much like to release our own software to production, but it cannot be done with snapshot releases inside. Do you have plans for a release soon?

@neotyk
Copy link
Collaborator

neotyk commented Oct 8, 2012

I was planning to update documentation first, but will cut release today without it.
Will keep you posted.

@erlingmat
Copy link
Author

Great thank you :)

@neotyk
Copy link
Collaborator

neotyk commented Oct 8, 2012

Release available in https://clojars.org/http.async.client

@neotyk neotyk closed this as completed Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants