Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

provide better documentation of tags #352

Open
groob opened this issue Jan 24, 2018 · 4 comments
Open

provide better documentation of tags #352

groob opened this issue Jan 24, 2018 · 4 comments

Comments

@groob
Copy link
Contributor

groob commented Jan 24, 2018

I don't quite get tags. Are they similar to prometheus labels? Do they work with traces? Or only stats? How are they match existing exporter nomenclature?

The documentation states:

Tags provide additional cardinality to
the OpenCensus instrumentation data.

I use Stackdriver and tried adding a few tags to my trace context, but had no way to see this data in my GCP trace view. Turns out they're called "Labels" in stackdriver and labels are populated using the trace. SetSpanAttributes function.

Better documentation on tags as well as how various Census concepts relate to existing exporters would help a lot.

@semistrict
Copy link
Contributor

Thanks for the feedback. Tags are not related to traces, they are related to stats. For example they turn into Prometheus labels. Span attributes / Stackdriver trace labels are a totally different thing.

Agree that each exporter should document the mapping from Census concepts to backend that they implement.

@rakyll
Copy link
Contributor

rakyll commented Jan 25, 2018

/cc @bogdandrutu

We should also determine whether we want to apply the tags as attributes on spans.

@rakyll rakyll added the docs label Jan 30, 2018
@julianvmodesto
Copy link
Contributor

julianvmodesto commented Dec 28, 2018

+1 this is confusing! I thought that OpenCensus tags were passed as Datadog APM Trace metadata, but OpenCensus attributes are actually the key-values that are passed as Datadog APM Trace metadata.

This is further confusing because the OpenCensus Datadog exporter calls its metadata tags in the library:
https://github.com/DataDog/opencensus-go-exporter-datadog/blob/2bef335f5ffffcfa296102765c21882a9158e52a/span.go#L81-L83

@tmc
Copy link

tmc commented Mar 24, 2019

/cc @bogdandrutu

We should also determine whether we want to apply the tags as attributes on spans.

Has there been further discussion of this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants