You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Currently the Java implementation sets a trace's status code as 0 for success unconditionally if there is a message or not.
However, the Go implementation doesn't set it and has an explicit check to ensure that we only send the status code if it isn't 0(SUCCESS) or if there is a message
We need to be consistent, and for each implementation, what's the rule on what status codes to ignore? If there is one, let's document it too in each implementation otherwise
The text was updated successfully, but these errors were encountered:
What's the difference between having an explicit 0 status vs having none? If it is a significant different, we should also represent this in the APIs by allowing a nil Status case.
If there is no significant difference, then zero value doesn't have to be reported.
Currently the Java implementation sets a trace's status code as 0 for success unconditionally if there is a message or not.
However, the Go implementation doesn't set it and has an explicit check to ensure that we only send the status code if it isn't 0(SUCCESS) or if there is a message
opencensus-go/exporter/stackdriver/trace_proto.go
Lines 66 to 68 in fbaec82
We need to be consistent, and for each implementation, what's the rule on what status codes to ignore? If there is one, let's document it too in each implementation otherwise
The text was updated successfully, but these errors were encountered: