This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
zpages: add option for enabling / disabling zpages at startup time #772
Labels
Comments
Agree this would be better enabled at runtime. |
semistrict
pushed a commit
that referenced
this issue
Jun 7, 2018
We still need to actually remove zpage.Handler before we can remove the eager initialization. Will will do this in around a month according to the deprecation policy. See: #772
Thank you for filing this @toffaletti and thanks @Ramonza for working on it! @Ramonza do you think we should remove that init invocation that enables zpages on the zpages.Handler variable? What else could we do here? Thank you. |
odeke-em
changed the title
Option for enabling / disabling zpages at startup time
zpages: add option for enabling / disabling zpages at startup time
Aug 20, 2018
FYI in Java ZPages needs to be explicitly initialized in application code: |
I think we can go ahead now and remove the Handler var that causes eager init. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It is a bit surprising that just importing zpages package (even if you don't register a handler) causes the infinite memory growth described in #597 even if DefaultSampler is NeverSample because of
and
This means enabling / disabling has to be done with a build tag right now, but a runtime command line flag would be best.
The text was updated successfully, but these errors were encountered: