Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Log correlation for Go #950

Open
smthpickboy opened this issue Oct 19, 2018 · 1 comment
Open

Log correlation for Go #950

smthpickboy opened this issue Oct 19, 2018 · 1 comment
Labels

Comments

@smthpickboy
Copy link

smthpickboy commented Oct 19, 2018

Is your feature request related to a problem? Please describe.

Log correlation draft:
https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/LogCorrelation.md
Java implementation:
https://github.com/census-instrumentation/opencensus-java/tree/master/contrib/log_correlation/log4j2

Since there's no dominant logging library in Golang(unlike Java), things are a bit more complicated here. So I wonder if there's a plan to implement log correlation for Go?

Describe the solution you'd like

Integrated contextual logging support for popular logging libraries like logrus, zap, etc.

Describe alternatives you've considered

Related issue:
census-instrumentation/opencensus-specs#130

@ghostsquad
Copy link

It would be great if this client supporting a Logger interface as a dependency. Something like

https://godoc.org/github.com/go-kit/kit/log

type Logger interface {
    Log(keyvals ...interface{}) error
}

That way you can pass in your needed logger (go-kit native logger) or an adapter for logrus, zap, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants