Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

@opencensus/core types.js #137

Open
wesfl opened this issue Oct 9, 2018 · 2 comments
Open

@opencensus/core types.js #137

wesfl opened this issue Oct 9, 2018 · 2 comments

Comments

@wesfl
Copy link

wesfl commented Oct 9, 2018

Hi there,

I'm brand new to both OpenCensus and TypeScript so apologies ahead of time if there's something I'm misunderstanding.

After npm i-ing @opencensus/core (which resolved to 0.0.4), I encountered an issue where the enum-s in build/src/stats/types.d.ts aren't represented in build/src/stats/types.js which lead to runtime errors like

Cannot read property 'KBYTE' of undefined

I pulled the opencensus-node project, and executed npm run compile, and the resulting types.js included code for those enum-s.

My initial thought is that @opencensus/core simply needs a new version published after a successful build. So, I wanted to submit an issue for discussion on this.

@BrianChristie
Copy link

I can confirm, I've tested the NodeJS Metrics QuickStart with the current master of opencensus/core and it works successfully.

Can we get a new release cut and pushed to NPM?

@songy23
Copy link
Contributor

songy23 commented Oct 15, 2018

@kjin could you do a new release to NPM?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants