Skip to content

Commit 80317c4

Browse files
committed
Better method names
1 parent 6f59c39 commit 80317c4

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

src/main/java/org/mybatis/dynamic/sql/delete/DeleteDSL.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,17 @@ public R build() {
5757
return adapterFunction.apply(deleteModel);
5858
}
5959

60-
public static <R> DeleteDSL<R> genericDeleteFrom(SqlTable table, Function<DeleteModel, R> adapterFunction) {
60+
public static <R> DeleteDSL<R> deleteFrom(Function<DeleteModel, R> adapterFunction, SqlTable table) {
6161
return new DeleteDSL<>(table, adapterFunction);
6262
}
6363

6464
public static DeleteDSL<DeleteModel> deleteFrom(SqlTable table) {
65-
return genericDeleteFrom(table, Function.identity());
65+
return deleteFrom(Function.identity(), table);
6666
}
6767

68-
public static <T> DeleteDSL<MyBatis3DeleteModelAdapter<T>> deleteFrom(SqlTable table,
69-
Function<DeleteStatement, T> mapperMethod) {
70-
return genericDeleteFrom(table, deleteModel -> MyBatis3DeleteModelAdapter.of(deleteModel, mapperMethod));
68+
public static <T> DeleteDSL<MyBatis3DeleteModelAdapter<T>> deleteFromWithMapper(
69+
Function<DeleteStatement, T> mapperMethod, SqlTable table) {
70+
return deleteFrom(deleteModel -> MyBatis3DeleteModelAdapter.of(deleteModel, mapperMethod), table);
7171
}
7272

7373
public class DeleteWhereBuilder extends AbstractWhereDSL<DeleteWhereBuilder> {

src/main/java/org/mybatis/dynamic/sql/select/SelectDSL.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -55,34 +55,34 @@ private QueryExpressionDSL<R> distinctQueryExpressionBuilder(BasicColumn...selec
5555
.build();
5656
}
5757

58-
public static <R> QueryExpressionDSL<R> genericSelect(Function<SelectModel, R> adapterFunction,
58+
public static <R> QueryExpressionDSL<R> select(Function<SelectModel, R> adapterFunction,
5959
BasicColumn...selectList) {
6060
SelectDSL<R> selectModelBuilder = new SelectDSL<>(adapterFunction);
6161
return selectModelBuilder.queryExpressionBuilder(selectList);
6262
}
6363

64-
public static <R> QueryExpressionDSL<R> genericSelectDistinct(Function<SelectModel, R> adapterFunction,
64+
public static <R> QueryExpressionDSL<R> selectDistinct(Function<SelectModel, R> adapterFunction,
6565
BasicColumn...selectList) {
6666
SelectDSL<R> selectModelBuilder = new SelectDSL<>(adapterFunction);
6767
return selectModelBuilder.distinctQueryExpressionBuilder(selectList);
6868
}
6969

7070
public static QueryExpressionDSL<SelectModel> select(BasicColumn...selectList) {
71-
return genericSelect(Function.identity(), selectList);
71+
return select(Function.identity(), selectList);
7272
}
7373

74-
public static <T> QueryExpressionDSL<MyBatis3SelectModelAdapter<T>> select(
74+
public static <T> QueryExpressionDSL<MyBatis3SelectModelAdapter<T>> selectWithMapper(
7575
Function<SelectStatement, T> mapperMethod, BasicColumn...selectList) {
76-
return genericSelect(selectModel -> MyBatis3SelectModelAdapter.of(selectModel, mapperMethod), selectList);
76+
return select(selectModel -> MyBatis3SelectModelAdapter.of(selectModel, mapperMethod), selectList);
7777
}
7878

7979
public static QueryExpressionDSL<SelectModel> selectDistinct(BasicColumn...selectList) {
80-
return genericSelectDistinct(Function.identity(), selectList);
80+
return selectDistinct(Function.identity(), selectList);
8181
}
8282

83-
public static <T> QueryExpressionDSL<MyBatis3SelectModelAdapter<T>> selectDistinct(
83+
public static <T> QueryExpressionDSL<MyBatis3SelectModelAdapter<T>> selectDistinctWithMapper(
8484
Function<SelectStatement, T> mapperMethod, BasicColumn...selectList) {
85-
return genericSelectDistinct(selectModel -> MyBatis3SelectModelAdapter.of(selectModel, mapperMethod),
85+
return selectDistinct(selectModel -> MyBatis3SelectModelAdapter.of(selectModel, mapperMethod),
8686
selectList);
8787
}
8888

src/main/java/org/mybatis/dynamic/sql/update/UpdateDSL.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,17 @@ public R build() {
7171
return adapterFunction.apply(updateModel);
7272
}
7373

74-
public static <R> UpdateDSL<R> genericUpdate(Function<UpdateModel, R> adapterFunction, SqlTable table) {
74+
public static <R> UpdateDSL<R> update(Function<UpdateModel, R> adapterFunction, SqlTable table) {
7575
return new UpdateDSL<>(table, adapterFunction);
7676
}
7777

7878
public static UpdateDSL<UpdateModel> update(SqlTable table) {
79-
return genericUpdate(Function.identity(), table);
79+
return update(Function.identity(), table);
8080
}
8181

82-
public static <T> UpdateDSL<MyBatis3UpdateModelAdapter<T>> update(Function<UpdateStatement, T> mapperMethod,
82+
public static <T> UpdateDSL<MyBatis3UpdateModelAdapter<T>> updateWithMapper(Function<UpdateStatement, T> mapperMethod,
8383
SqlTable table) {
84-
return genericUpdate(updateModel -> MyBatis3UpdateModelAdapter.of(updateModel, mapperMethod), table);
84+
return update(updateModel -> MyBatis3UpdateModelAdapter.of(updateModel, mapperMethod), table);
8585
}
8686

8787
public class SetClauseFinisher<T> {

src/test/java/examples/simple/SimpleTableAnnotatedMapper.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,12 @@ public interface SimpleTableAnnotatedMapper {
7575
long count(SelectStatement selectStatement);
7676

7777
default QueryExpressionDSL<MyBatis3SelectModelAdapter<Long>>.QueryExpressionAfterFrom countByExample() {
78-
return SelectDSL.select(this::count, SqlBuilder.count())
78+
return SelectDSL.selectWithMapper(this::count, SqlBuilder.count())
7979
.from(simpleTable);
8080
}
8181

8282
default DeleteDSL<MyBatis3DeleteModelAdapter<Integer>> deleteByExample() {
83-
return DeleteDSL.deleteFrom(simpleTable, this::delete);
83+
return DeleteDSL.deleteFromWithMapper(this::delete, simpleTable);
8484
}
8585

8686
default int deleteByPrimaryKey(Integer id_) {
@@ -117,7 +117,7 @@ default int insertSelective(SimpleTableRecord record) {
117117
}
118118

119119
default QueryExpressionDSL<MyBatis3SelectModelAdapter<List<SimpleTableRecord>>>.QueryExpressionAfterFrom selectByExample() {
120-
return SelectDSL.select(this::selectMany, id.as("A_ID"), firstName, lastName, birthDate, employed, occupation)
120+
return SelectDSL.selectWithMapper(this::selectMany, id.as("A_ID"), firstName, lastName, birthDate, employed, occupation)
121121
.from(simpleTable);
122122
}
123123

@@ -130,7 +130,7 @@ default SimpleTableRecord selectByPrimaryKey(Integer id_) {
130130
}
131131

132132
default UpdateDSL<MyBatis3UpdateModelAdapter<Integer>> updateByExample(SimpleTableRecord record) {
133-
return UpdateDSL.update(this::update, simpleTable)
133+
return UpdateDSL.updateWithMapper(this::update, simpleTable)
134134
.set(id).equalTo(record.getId())
135135
.set(firstName).equalTo(record.getFirstName())
136136
.set(lastName).equalTo(record.getLastName())
@@ -140,7 +140,7 @@ default UpdateDSL<MyBatis3UpdateModelAdapter<Integer>> updateByExample(SimpleTab
140140
}
141141

142142
default UpdateDSL<MyBatis3UpdateModelAdapter<Integer>> updateByExampleSelective(SimpleTableRecord record) {
143-
return UpdateDSL.update(this::update, simpleTable)
143+
return UpdateDSL.updateWithMapper(this::update, simpleTable)
144144
.set(id).equalToWhenPresent(record.getId())
145145
.set(firstName).equalToWhenPresent(record.getFirstName())
146146
.set(lastName).equalToWhenPresent(record.getLastName())

0 commit comments

Comments
 (0)