[avalanche] Rename the peer set tag proof_index => by_proofid for con…

…sistency

Summary:
This is more consistent with other multi index tags, and this will also make it possible to templatize the `proof_index` structure so it can be used to index something else than a peer. There is no change in behavior.

Ref T1854.

Test Plan:
  ninja all check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T1854

Differential Revision: https://reviews.bitcoinabc.org/D10520

Add a release note for the 0.24.6 checkpoint

Summary: As per title.

Test Plan: Read it.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D10477

net: Print error message if -proxy is specified without arguments (in…

…stead of continuing without proxy server)

Summary: This is a backport of [[bitcoin/bitcoin#20003 | core#20003]]

Test Plan: `ninja && test/functional/test_runner.py feature_config_args`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10400

[Automated] Update timing.json

[avalanche] Extract the vote status in an enum class

Summary:
This moves the Status enum out of the BlockUpdate class. This makes it possible to use the same status values for conflicting proofs. Another diff will extract an API from BlockUpdate to make it possilble to build a ProofUpdate class sharing the same interface.

VoteStatus is an enum class and cannot have an operator<<() method, so we need to update the tests to use BOOST_CHECK instead of BOOST_CHECK_EQUAL. Apart from this there is no change in behavior.

Ref T1854.

Test Plan:
  ninja all check-all

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T1854

Differential Revision: https://reviews.bitcoinabc.org/D10249

rpc: Assert that RPCArg names are equal to CRPCCommand ones (rpcdump)

Summary:
This concludes backport of [[bitcoin/bitcoin#19717 | core#19717]] [4/4]
bitcoin/bitcoin@fa3d9ce

Depends on D10147, D10149 and D10159

Note: the forward declaration of RPC functions in rpcwallet.cpp don't seem to exist in Bitcoin ABC, and the ones in wallet_tests.cpp were in rpcdump.h (see D45)

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10148

tests: use common NodeContext in wallet_tests.cpp::ZapSelectTx

Summary:
D9989 broke `src/test/test_bitcoin`. This was not noticed until now
because most of the time we run the tests via `ninja check`, which
didn't fail (presumably because with `ninja check` there are not
concurrent wallets loaded at the same time).

This fixes it by using the common node context from `BasicTestingSetup`
to load the wallet, rather than creating a fresh `NodeContext`.

Test Plan:
```
ninja && ninja check
ninja test_bitcoin && src/test/test_bitcoin
```

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10029

Bump version to 0.24.0

Summary: As title

Test Plan:
  ninja print-version

Reviewers: #bitcoin_abc, josephroyking

Reviewed By: #bitcoin_abc, josephroyking

Differential Revision: https://reviews.bitcoinabc.org/D9911

Bump version to 0.23.10

Summary: As per title.

Test Plan:
  ninja print-version

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D9854

add some release notes for 0.23.9

Summary: as title

Test Plan:
  read it

Reviewers: #bitcoin_abc, josephroyking

Reviewed By: #bitcoin_abc, josephroyking

Differential Revision: https://reviews.bitcoinabc.org/D9835