Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: Open search results in separate page #201

Closed
chancez opened this issue Nov 28, 2022 · 16 comments
Closed

feature-request: Open search results in separate page #201

chancez opened this issue Nov 28, 2022 · 16 comments

Comments

@chancez
Copy link

chancez commented Nov 28, 2022

Currently when searching on the cilium blog, the results are displayed in a small list pop-up in the page, and has an option to "expand" to see more. Ideally we would also offer an option to open the results in a new page, which would be easier to look for results in.

@kayceeDev
Copy link

kayceeDev commented Feb 3, 2023

@chancez if I understand you correctly, you want a "See more button" that takes the user to another page containing the blogs that match the search results right?

Will this is great, what is the intention of this feature? Does it help the UX since there is already a "View All" button in the pop-up?

If there is still a need, will these returned search results be paginated on the new page assuming it is too long?

Will the new page also contains another search box assuming the user what to filter from the originally filtered result. will it have a filter by-tag button like in the "All posts" sections?

@chancez
Copy link
Author

chancez commented Feb 3, 2023

The intent is that it's easier to view results as I mentioned. Trying to view the search results in the tiny drop down is pretty bad UX when trying to look through a large list of search results.

@kayceeDev
Copy link

The intent is that it's easier to view results as I mentioned. Trying to view the search results in the tiny drop down is pretty bad UX when trying to look through a large list of search results.

Alright. I will like to take a dig at this.

@divz-codess
Copy link

Hi @xmulligan @kayceeDev @chancez I had an idea to expand the search bar upon being clicked and collapse options on the right (Enterprise, Learn, etc.) into a drop-down and again contract the search bar after search completion. If that sounds alright?

@xmulligan
Copy link
Member

@divz-codess do you mean on docs.cilium.io or on cilium.io?

@divz-codess
Copy link

@xmulligan the issue is at https://cilium.io/blog/ so I meant to change it there.

@Shubhamlmp
Copy link

Hi @chancez I think what I find the solution for this problem is instead of expanding search bar and this small drop down. when user click on search button we can open a full page size search modal.
Please let me know if it is okay for you?

@xmulligan
Copy link
Member

I think @chancez was looking for what @Shubhamlmp wrote

@chancez
Copy link
Author

chancez commented Feb 23, 2023

Yeah, that seems reasonable.

@Shubhamlmp
Copy link

@chancez @xmulligan So, can I do some r&d on this and start working?

@divz-codess
Copy link

@chancez @xmulligan I think that having a modal only for searching blogs isn't much needed as at the end we are just displaying the blog titles and a short description so a modal dedicated for searching won't be required.
Your opinions are most welcome :)

@Neilblaze
Copy link
Contributor

Been following some design patterns for a while, & after a few iterations, I came up with this 👇🏼

Current New (proposed)
current_cilium new_cilium

I've crafted it in a way that maintains the overall UX consistency of the website making it a perfect fit! I do believe that it'll look even better in dark-mode if it's added to the blog in near future.

"...option to open the results in a new page, which would be easier to look for results in."

The updated search solves the above issue. One just needs to click on the "open in a new tab" button to open that particular link in a new tab. Additionally, I've proposed a few more features in the same which will help maintainers & active users keep a track of the page-visits. Plus, one can even opt to share the link with anyone or copy the source link to the clipboard with just a simple click!

cc: @chancez, @xmulligan

@xmulligan
Copy link
Member

@Neilblaze I think @chancez was asking for something slightly different. When searching, he wants all of the results to open in a new page not being able to open individual results on a new page. Does that make sense?

@Neilblaze
Copy link
Contributor

Makes sense now. So, that simply means, clicking on the search button will redirect the user to a new ../search page, and the rest will be just as it is, correct? @xmulligan

@xmulligan
Copy link
Member

Yes, that's correct

@xmulligan
Copy link
Member

I think we can close this with #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants