Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show Edit button when you click on other options #32

Closed
amercader opened this issue Apr 5, 2018 · 2 comments
Closed

Don't show Edit button when you click on other options #32

amercader opened this issue Apr 5, 2018 · 2 comments
Assignees
@roll

Comments

@amercader
Copy link
Member

If you click on Upload , Link or JSON the "Edit" button should disappear to be consistent.

A related but separate issue is whether you should be able to edit existing schemas (uploaded or pasted in the JSON field) with the editor. I think you should. In practice that would mean prefilling the editor component with the contents of the hidden schema field, if present and with a value.
@roll roll mentioned this issue Apr 6, 2018
Open
@roll
Copy link
Contributor

roll commented Apr 6, 2018 •
edited
Loading

So we support provided schema editing (e.g. upload schema and click edit) - so the thing here to decide what's the best UI for it on the form level.

@roll roll self-assigned this Apr 6, 2018
@roll
Copy link
Contributor

roll commented Apr 10, 2018

FIxed/Moved in #25/#34

@roll roll closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roll roll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amercader @roll