Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object Object] error on thumbnail #16

Closed
petenice opened this issue May 27, 2015 · 6 comments
Closed

[object Object] error on thumbnail #16

petenice opened this issue May 27, 2015 · 6 comments

Comments

@petenice
Copy link

{my_field_name:thumbnail} returning [object Object] error

@bryanburgers
Copy link
Contributor

@petenice Thanks for reporting this issue. Would you mind answering a few questions so I can get to the bottom of this?

  • What version of videolink are you using?
  • Are you trying to embed a YouTube video or a Vimeo video?
  • What browser were you using to access the control panel when you embedded the video?
  • Does that tag return "[object Object]" or "[object Object] error"?
  • Does this occur when you resave an existing entry? Or does it occur when you create a new entry?

@petenice
Copy link
Author

petenice commented Jun 3, 2015

Sorry about the delay. Answers follow:

  1. VideoLink 1.5.0
  2. Trying to embed YouTube video
  3. Browsering with Chrome 43
  4. I believe it returned "[object Object]"
  5. Error occured when creating a new entry

Thank you for your excellent work and helpful contribution! It's a great tool.

@peteheaney
Copy link
Contributor

I was going to create a new issue, but I think this is probably the same thing....

The JSON feed returned by the YouTube API has changed. You need to update videolink.js. Change line 34 from:

'thumbnail': data.items[0].snippet.thumbnails.maxres

to:

'thumbnail': data.items[0].snippet.thumbnails.high.url

@bryanburgers
Copy link
Contributor

@peteheaney Thanks for finding that! Would you be willing to submit a pull request?

@bryanburgers
Copy link
Contributor

@petenice I believe this is fixed because of Pull Request #18. I've merged that into master. Can you give that a try to see if it fixes your problem before I cut a release?

@petenice
Copy link
Author

petenice commented Jun 8, 2015

Success! Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants