network: add retries for get network adapter name by MAC's address #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more retries for get network adapter name by MAC's address.
ader1990
reviewed
Jun 19, 2020
| @@ -799,6 +799,8 @@ def set_ntp_client_config(self, ntp_hosts): | |||
| 'w32tm failed to configure NTP.\nOutput: %(out)s\nError:' | |||
| ' %(err)s' % {'out': out, 'err': err}) | |||
|
|
|||
| @retry_decorator.retry_decorator( | |||
There was a problem hiding this comment.
I would advise to set the service to automatic delayed start in these cases. If the OS does not see the adapter, there is a problem with the nic drivers or a concurrency issue between the cloudbase-init service and the networking service.
|
Hello, I think this fix has been addressed by multiple patches that were merged recently, both in the installer and the cloudbase-init code. @noliaoliao can you please confirm the issue is no longer present? Thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more retries for get network adapter name by MAC's address.