GEODE-4353: Deprecating security-client-dhalgo

GEODE-4353: Deprecating security-client-dhalgo

Deprecating this property and removing description from the manual.

Author: upthewaterspout

geode-book/master_middleman/source/subnavs/geode-subnav.erb

@@ -588,9 +588,6 @@ limitations under the License.
                                     <li>
                                         <a href="/docs/guide/<%=vars.product_version_nodot%>/managing/security/implementing_authentication.html">Implementing Authentication</a>
                                     </li>
-                                    <li>
-                                        <a href="/docs/guide/<%=vars.product_version_nodot%>/managing/security/encrypting_with_diffie_hellman.html">Encrypt Credentials with Diffie-Hellman</a>
-                                    </li>
                                     <li>
                                         <a href="/docs/guide/<%=vars.product_version_nodot%>/managing/security/authentication_examples.html">Authentication Example</a>
                                     </li>

geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java

@@ -1495,6 +1495,8 @@ public interface ConfigurationProperties {
   String SECURITY_CLIENT_AUTHENTICATOR = SECURITY_PREFIX + "client-authenticator";
   /**
    * The static String definition of the <i>"security-client-dhalgo"</i> property
+   *
+   * @deprecated since Geode 1.5. Use SSL instead. See {{@link #SSL_ENABLED_COMPONENTS}}
    */
   String SECURITY_CLIENT_DHALGO = SECURITY_PREFIX + "client-dhalgo";
   /**

geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java

@@ -2056,7 +2056,8 @@ public interface DistributionConfig extends Config, LogConfig {
   String SECURITY_CLIENT_DHALGO_NAME = SECURITY_CLIENT_DHALGO;
 
   /**
-   * The name of the Diffie-Hellman symmetric algorithm "security-client-dhalgo" property.
+   * The name of the Diffie-Hellman symmetric algorithm "security-udp-dhalgo" property.
+   *
    */
   @ConfigAttribute(type = String.class)
   String SECURITY_UDP_DHALGO_NAME = SECURITY_UDP_DHALGO;

geode-docs/managing/security/authentication_overview.html.md.erb

@@ -27,10 +27,6 @@ system such as peers, clients, and those connecting to a JMX manager.
     All components of the distributed system authenticate the same way,
     through a custom-written method.
 
--   **[Encrypt Credentials with Diffie-Hellman](encrypting_with_diffie_hellman.html)**
-
-    For secure transmission of sensitive information, like passwords, you can encrypt credentials using the Diffie-Hellman key exchange algorithm.
-
 -   **[Authentication Example](authentication_examples.html)**
 
     The example demonstrates the basics of an implementation of the

geode-docs/managing/security/encrypting_with_diffie_hellman.html.md.erb

@@ -524,7 +524,10 @@ Any security-related (properties that begin with <code class="ph codeph">securit
 </tr>
 <tr class="even">
 <td>security-client-dhalgo</td>
-<td>Used for authentication. For secure transmission of sensitive credentials like passwords, you can encrypt the credentials using the Diffie-Hellman key exchange algorithm. Do this by setting the security-client-dhalgo system property on the clients to the name of a valid symmetric key cipher supported by the JDK.</td>
+<td><strong>Deprecated.</strong> Use <code class="ph codeph">ssl-enabled-components</code> instead.
+<br>Used for authentication. For secure transmission of sensitive credentials like passwords, you can encrypt the credentials using the Diffie-Hellman\
+ key exchange algorithm. Do this by setting the security-client-dhalgo system property on the clients to the name of a valid symmetric key cipher supp\
+orted by the JDK.</td>
 <td>S, L</td>
 <td><em>not set</em></td>
 </tr>