-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTracing color icon SVG is not centered #14
Comments
lukaszgryglicki
changed the title
OpenTracing color icon SVG is not centred
OpenTracing color icon SVG is not centered
Nov 17, 2017
This was referenced Nov 17, 2017
Created PR with fix: #15 |
I think a square image should be used such as the one attached
Rad
On Friday, November 17, 2017, 2:31:41 PM GMT+1, Łukasz Gryglicki <[email protected]> wrote:
Created PR with fix: #15
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@radoslaw I don't understand your message. Lukasz's logo is square: https://github.com/lukaszgryglicki/artwork/blob/cee57a435f5f3dec6808cefbbd73e368edc452e9/opentracing/icon/color/opentracing-icon-color.svg |
no, it is 1000x878
Rad
On Friday, November 17, 2017, 3:34:53 PM GMT+1, Dan Kohn <[email protected]> wrote:
@radoslaw I don't understand your message. Lukasz's logo is square: https://github.com/lukaszgryglicki/artwork/blob/cee57a435f5f3dec6808cefbbd73e368edc452e9/opentracing/icon/color/opentracing-icon-color.svg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Good point. That may also be why it is not centered in the circle at
https://opentracing.cncftest.io/dashboard/db/dashboards?refresh=15m&orgId=1
Could you please work with Lukasz and one of you can update.
…--
Dan Kohn <[email protected]>
Executive Director, Cloud Native Computing Foundation https://www.cncf.io
+1-415-233-1000 https://www.dankohn.com
On Fri, Nov 17, 2017 at 9:37 AM, Radoslaw Dziegielewski <
[email protected]> wrote:
no, it is 1000x878
Rad
On Friday, November 17, 2017, 3:34:53 PM GMT+1, Dan Kohn <
***@***.***> wrote:
@radoslaw I don't understand your message. Lukasz's logo is square:
https://github.com/lukaszgryglicki/artwork/blob/
cee57a4/opentracing/icon/
color/opentracing-icon-color.svg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AC8MBpR98X2q41VGYVXIw_lVjq6E2-Dkks5s3Zo4gaJpZM4Qh-St>
.
|
I can create another PR on Monday. Sorry :( I have no more time today. |
Closing for #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
OpenTracing SVG file is not centered.
See this (GIMP):
This SVG file:
https://github.com/cncf/artwork/blob/master/opentracing/icon/color/opentracing-icon-color.svg
Originally requested here: cncf/devstats#18
The text was updated successfully, but these errors were encountered: