New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to relative URLs in Readme #26

Closed

dankohn opened this issue Jan 16, 2018 · 1 comment

Assignees

Contributor

dankohn commented Jan 16, 2018

Every URL in the Readme is pointing to your fork instead of the main repo. You need to use relative URLs.

Change every URL of https://github.com/alexcontini/artwork/blob/master/prometheus/horizontal/color/prometheus-horizontal-color.png to /master/prometheus/horizontal/color/prometheus-horizontal-color.png

Start with just one to confirm the relative URLs are working correctly. Please Slack me with questions.

Separately, you seem to be using an undocumented feature of GitHub in accessing https://github.com/alexcontini/artwork/blob/master/prometheus/horizontal/color/prometheus-horizontal-color.png (which normally serves HTML) instead of https://raw.githubusercontent.com/alexcontini/artwork/master/prometheus/horizontal/color/prometheus-horizontal-color.png (which just serves the PNG). But it's working, so it's probably not worth changing.

dankohn assigned alexcontini

Contributor Author

dankohn commented Jan 18, 2018

Fixed in 3880480

dankohn closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment