Skip to content

Commit 2f9e00f

Browse files
committed
release,build: don't imply lintonbuild in ci configuration
The `ci` configuration is overloaded and is used for a few different things. It is used in builds to enable `lintonbuild`, and it's used in tests to set some configurations that are useful in TeamCity (increased verbosity, etc.) While running lints every time we build in a paranoid, repetitive fashion does mean that lint issues cannot go unnoticed, it does have a performance impact (see #136626). Going forward, we will not have this configuration imply `lintonbuild` and provide the option to disable `nogo` for certain builds in automation. For example, `roachtest`s will benefit from having lints disabled as well to speed up the build. Here, we do the following: 1. Have `--config=ci` not imply enabling lints 2. Now, `--config=ci` has no specific meaning for builds (it's only meaningful for tests). So, I go through all the scripts and automation and remove it for builds specifically. 3. Disable `nogo` for release builds to reduce the likelihood of an OOM. Part of: #136626 Epic: CRDB-41952 Release note: None
1 parent 164ce7c commit 2f9e00f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+243
-239
lines changed

.bazelrc

+4-4
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,15 @@ test:race --heavy
6161

6262
# CI uses a custom timeout for enormous targets.
6363
test:use_ci_timeouts --test_timeout=60,300,900,900
64+
6465
# CI should always run with `--config=ci`.
65-
build:cibase --config=lintonbuild
6666
# Set `-test.v` in Go tests.
6767
# Ref: https://github.com/bazelbuild/rules_go/pull/2456
68-
test:cibase --test_env=GO_TEST_WRAP_TESTV=1
68+
test:ci --test_env=GO_TEST_WRAP_TESTV=1
6969
# Dump all output for failed tests to the build log.
7070
test:ci --test_output=errors
7171
# Put all tmp artifacts in /artifacts/tmp.
7272
test:ci --test_tmpdir=/artifacts/tmp
73-
build:ci --config=cibase
7473

7574
build:cross --stamp
7675

@@ -132,7 +131,8 @@ build:engflowbase --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
132131
build:engflowbase --extra_execution_platforms=//build/toolchains:cross_linux
133132
build:engflowbase --remote_upload_local_results=false
134133
build:engflowbase --remote_download_toplevel
135-
build:engflowbase --config=cibase
134+
build:engflowbase --test_env=GO_TEST_WRAP_TESTV=1
135+
build:engflowbase --config=lintonbuild
136136
test:engflowbase --test_env=REMOTE_EXEC=1
137137
test:engflowbase --test_env=GOTRACEBACK=all
138138
build:engflow --config=engflowbase

build/teamcity/cockroach/ci/builds/build_impl.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ then
4242
GEOS_TARGET=
4343
fi
4444

45-
bazel build //pkg/cmd/bazci --config=ci
46-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
45+
bazel build //pkg/cmd/bazci
46+
BAZEL_BIN=$(bazel info bazel-bin)
4747
"$BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci" -- build -c opt \
48-
--config "$CONFIG" --config ci $EXTRA_ARGS \
48+
--config "$CONFIG" $EXTRA_ARGS \
4949
//pkg/cmd/cockroach-short //pkg/cmd/cockroach \
5050
//pkg/cmd/cockroach-sql $GEOS_TARGET $EXTRA_TARGETS
5151

build/teamcity/cockroach/ci/tests-aws-linux-arm64-bigvm/unit_tests_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dir="$(dirname $(dirname $(dirname $(dirname $(dirname "${0}")))))"
1212

1313
source "$dir/teamcity-support.sh" # for 'tc_release_branch'
1414

15-
bazel build //pkg/cmd/bazci --config=ci
15+
bazel build //pkg/cmd/bazci
1616

1717
EXTRA_PARAMS=""
1818

@@ -21,6 +21,6 @@ if tc_bors_branch; then
2121
EXTRA_PARAMS=" --flaky_test_attempts=2"
2222
fi
2323

24-
$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=use_ci_timeouts -c fastbuild \
24+
$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=use_ci_timeouts -c fastbuild \
2525
//pkg:all_tests \
2626
--profile=/artifacts/profile.gz $EXTRA_PARAMS

build/teamcity/cockroach/ci/tests-aws-linux-arm64/acceptance.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ else
1919
fi
2020

2121
tc_start_block "Build cockroach"
22-
build_script='bazel build --config $1 --config ci //pkg/cmd/cockroach-short && cp $(bazel info bazel-bin --config $1 --config ci)/pkg/cmd/cockroach-short/cockroach-short_/cockroach-short /artifacts/cockroach && chmod a+w /artifacts/cockroach'
22+
build_script='bazel build --config $1 //pkg/cmd/cockroach-short && cp $(bazel info bazel-bin --config $1)/pkg/cmd/cockroach-short/cockroach-short_/cockroach-short /artifacts/cockroach && chmod a+w /artifacts/cockroach'
2323
run_bazel /usr/bin/bash -c "$build_script" -- "$CROSSLINUX_CONFIG"
2424
tc_end_block "Build cockroach"
2525

@@ -29,8 +29,8 @@ mkdir -p "$ARTIFACTSDIR"
2929
tc_start_block "Run acceptance tests"
3030
status=0
3131

32-
bazel build //pkg/cmd/bazci --config=ci
33-
BAZCI=$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci
32+
bazel build //pkg/cmd/bazci
33+
BAZCI=$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci
3434

3535
$BAZCI --artifacts_dir=$PWD/artifacts -- \
3636
test //pkg/acceptance:acceptance_test \

build/teamcity/cockroach/ci/tests-aws-linux-arm64/ui_test_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@
88

99
set -xeuo pipefail
1010

11-
bazel build //pkg/cmd/bazci --config=ci
12-
$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci //pkg/ui:test
11+
bazel build //pkg/cmd/bazci
12+
$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci //pkg/ui:test

build/teamcity/cockroach/ci/tests/local_roachtest_impl.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ else
1414
export CROSSLINUX_CONFIG="crosslinux"
1515
fi
1616

17-
BAZEL_BIN=$(bazel info bazel-bin --config=$CROSSLINUX_CONFIG --config=ci)
17+
BAZEL_BIN=$(bazel info bazel-bin --config=$CROSSLINUX_CONFIG)
1818

19-
bazel build --config=$CROSSLINUX_CONFIG --config=ci //pkg/cmd/cockroach-short \
19+
bazel build --config=$CROSSLINUX_CONFIG //pkg/cmd/cockroach-short \
2020
//pkg/cmd/roachtest \
2121
//pkg/cmd/roachprod \
2222
//pkg/cmd/workload
2323

24-
bazel build --config=$CROSSLINUX_CONFIG --config=ci --config=force_build_cdeps //c-deps:libgeos
24+
bazel build --config=$CROSSLINUX_CONFIG --config=force_build_cdeps //c-deps:libgeos
2525

2626
mkdir -p lib
2727
cp $BAZEL_BIN/c-deps/libgeos_foreign/lib/libgeos.so lib/libgeos.so

build/teamcity/cockroach/ci/tests/maybe_stress_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ fi
1616

1717
TARGET="$1"
1818

19-
bazel build //pkg/cmd/github-pull-request-make //pkg/cmd/bazci @com_github_cockroachdb_stress//:stress --config=ci
20-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
19+
bazel build //pkg/cmd/github-pull-request-make //pkg/cmd/bazci @com_github_cockroachdb_stress//:stress
20+
BAZEL_BIN=$(bazel info bazel-bin)
2121
PATH=$PATH:$BAZEL_BIN/pkg/cmd/bazci/bazci_:$BAZEL_BIN/external/com_github_cockroachdb_stress/stress_ TARGET=$TARGET \
2222
$BAZEL_BIN/pkg/cmd/github-pull-request-make/github-pull-request-make_/github-pull-request-make

build/teamcity/cockroach/ci/tests/testrace_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ set -xeuo pipefail
1111
# Usage: testrace_impl.sh PKG1 [PKG2 PKG3 PKG4...]
1212
# packages are expected to be formatted as go-style, e.g. ./pkg/cmd/bazci.
1313

14-
bazel build //pkg/cmd/bazci --config=ci
14+
bazel build //pkg/cmd/bazci
1515
size_to_timeout=("small:1200" "medium:6000" "large:18000" "enormous:72000")
1616
for pkg in "$@"
1717
do
@@ -35,7 +35,7 @@ do
3535
echo "Skipping test $test"
3636
continue
3737
fi
38-
$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=race "$test" \
38+
$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- test --config=ci --config=race "$test" \
3939
--test_env=COCKROACH_LOGIC_TESTS_SKIP=true \
4040
--test_timeout $timeout \
4141
--test_sharding_strategy=disabled \

build/teamcity/cockroach/coverage/unit_tests_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88

99
set -xeuo pipefail
1010

11-
bazel build //pkg/cmd/bazci --config=ci
11+
bazel build //pkg/cmd/bazci
1212

13-
$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- \
13+
$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- \
1414
coverage \
1515
--config=ci --config=use_ci_timeouts -c fastbuild \
1616
--@io_bazel_rules_go//go/config:cover_format=lcov --combined_report=lcov \

build/teamcity/cockroach/create-docs-issue.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ source "$dir/teamcity-support.sh"
1616
source "$dir/teamcity-bazel-support.sh"
1717

1818
BAZEL_SUPPORT_EXTRA_DOCKER_ARGS="-e GITHUB_API_TOKEN -e JIRA_API_TOKEN -e DOCS_ISSUE_GEN_END_TIME -e DOCS_ISSUE_GEN_START_TIME -e DRY_RUN_DOCS_ISSUE_GEN" run_bazel << 'EOF'
19-
bazel build --config ci //pkg/cmd/docs-issue-generation
20-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
19+
bazel build //pkg/cmd/docs-issue-generation
20+
BAZEL_BIN=$(bazel info bazel-bin)
2121
$BAZEL_BIN/pkg/cmd/docs-issue-generation/docs-issue-generation_/docs-issue-generation
2222
EOF

build/teamcity/cockroach/nightlies/cloud_unit_tests_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ set -xeuo pipefail
1111
dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))"
1212
source "$dir/teamcity-support.sh" # For log_into_gcloud
1313

14-
bazel build //pkg/cmd/bazci --config=ci
15-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
14+
bazel build //pkg/cmd/bazci
15+
BAZEL_BIN=$(bazel info bazel-bin)
1616

1717
ARTIFACTS_DIR=/artifacts
1818

build/teamcity/cockroach/nightlies/compose.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ source "$dir/teamcity-bazel-support.sh"
1414

1515
tc_start_block "Run compose tests"
1616

17-
bazel build //pkg/cmd/bazci --config=ci
18-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
17+
bazel build //pkg/cmd/bazci
18+
BAZEL_BIN=$(bazel info bazel-bin)
1919
BAZCI=$BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci
2020

21-
bazel build //pkg/cmd/cockroach //pkg/compose/compare/compare:compare_test //c-deps:libgeos --config=ci --config=crosslinux --config=test
22-
CROSSBIN=$(bazel info bazel-bin --config=ci --config=crosslinux --config=test)
21+
bazel build //pkg/cmd/cockroach //pkg/compose/compare/compare:compare_test //c-deps:libgeos --config=crosslinux --config=test
22+
CROSSBIN=$(bazel info bazel-bin --config=crosslinux --config=test)
2323
COCKROACH=$CROSSBIN/pkg/cmd/cockroach/cockroach_/cockroach
2424
COMPAREBIN=$CROSSBIN/pkg/compose/compare/compare/compare_test_/compare_test
25-
LIBGEOSDIR=$(bazel info execution_root --config=crosslinux --config=ci --config=test)/external/archived_cdep_libgeos_linux/lib/
25+
LIBGEOSDIR=$(bazel info execution_root --config=crosslinux --config=test)/external/archived_cdep_libgeos_linux/lib/
2626
ARTIFACTS_DIR=$PWD/artifacts
2727
mkdir -p $ARTIFACTS_DIR
2828

build/teamcity/cockroach/nightlies/lint_urls_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ bazel run //pkg/gen:code
1818
bazel run //pkg/cmd/generate-cgo:generate-cgo --run_under="cd $root && "
1919
# generated files requirements -- end
2020

21-
bazel build //pkg/cmd/bazci --config=ci
22-
$(bazel info bazel-bin --config=ci)/pkg/cmd/bazci/bazci_/bazci -- \
21+
bazel build //pkg/cmd/bazci
22+
$(bazel info bazel-bin)/pkg/cmd/bazci/bazci_/bazci -- \
2323
test //pkg/testutils/lint:lint_test \
2424
--config=ci --define gotags=bazel,gss,nightly,lint \
2525
--test_filter=TestNightlyLint \

build/teamcity/cockroach/nightlies/microbenchmark_build_support.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ function build_and_upload_binaries() {
2424
return
2525
fi
2626

27-
config_args="--config=crosslinux --config=ci --crdb_test_off"
27+
config_args="--config=crosslinux --crdb_test_off"
2828
bazel clean
2929
go_test_targets=$(bazel query kind\(go_test, //$BENCH_PACKAGE:all\))
3030
bazel build $config_args $go_test_targets

build/teamcity/cockroach/nightlies/microbenchmark_weekly.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ export SANITIZED_BENCH_PACKAGE=${SANITIZED_BENCH_PACKAGE/.../all}
5858

5959
# Build rochprod and roachprod-microbench
6060
run_bazel <<'EOF'
61-
bazel build --config ci --config crosslinux //pkg/cmd/roachprod //pkg/cmd/roachprod-microbench
62-
BAZEL_BIN=$(bazel info bazel-bin --config ci --config crosslinux)
61+
bazel build --config crosslinux //pkg/cmd/roachprod //pkg/cmd/roachprod-microbench
62+
BAZEL_BIN=$(bazel info bazel-bin --config crosslinux)
6363
mkdir -p bin
6464
cp $BAZEL_BIN/pkg/cmd/roachprod/roachprod_/roachprod bin
6565
cp $BAZEL_BIN/pkg/cmd/roachprod-microbench/roachprod-microbench_/roachprod-microbench bin

build/teamcity/cockroach/nightlies/optimizer_tests_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ set -xeuo pipefail
1111
dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))"
1212
source "$dir/teamcity/util.sh"
1313

14-
bazel build //pkg/cmd/bazci --config=ci
15-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
14+
bazel build //pkg/cmd/bazci
15+
BAZEL_BIN=$(bazel info bazel-bin)
1616

1717
tc_start_block "Run opt tests with fast_int_set_large"
1818
ARTIFACTS_DIR=/artifacts/fast_int_set_large

build/teamcity/cockroach/nightlies/pebble_nightly_build_test_binary.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ RESTORE_COMMIT=$(git rev-parse HEAD)
2525
git fetch origin "$CRDB_BRANCH"
2626
git checkout "origin/$CRDB_BRANCH"
2727

28-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
28+
BAZEL_BIN=$(bazel info bazel-bin)
2929

3030
bazel run @go_sdk//:bin/go get "github.com/cockroachdb/pebble@$PEBBLE_BRANCH"
3131

build/teamcity/cockroach/nightlies/pebble_nightly_common.sh

+6-6
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ mkdir -p "$PWD/bin"
3333
chmod o+rwx "$PWD/bin"
3434

3535
# Build the roachtest binary.
36-
bazel build //pkg/cmd/roachtest --config ci -c opt
37-
BAZEL_BIN=$(bazel info bazel-bin --config ci -c opt)
36+
bazel build //pkg/cmd/roachtest -c opt
37+
BAZEL_BIN=$(bazel info bazel-bin -c opt)
3838
cp $BAZEL_BIN/pkg/cmd/roachtest/roachtest_/roachtest bin
3939
chmod a+w bin/roachtest
4040

@@ -45,8 +45,8 @@ chmod a+w bin/roachtest
4545
bazel run @go_sdk//:bin/go get github.com/cockroachdb/pebble@master
4646
NEW_DEPS_BZL_CONTENT=$(bazel run //pkg/cmd/mirror/go:mirror)
4747
echo "$NEW_DEPS_BZL_CONTENT" > DEPS.bzl
48-
bazel build @com_github_cockroachdb_pebble//cmd/pebble --config ci -c opt
49-
BAZEL_BIN=$(bazel info bazel-bin --config ci -c opt)
48+
bazel build @com_github_cockroachdb_pebble//cmd/pebble -c opt
49+
BAZEL_BIN=$(bazel info bazel-bin -c opt)
5050
cp $BAZEL_BIN/external/com_github_cockroachdb_pebble/cmd/pebble/pebble_/pebble ./pebble.linux
5151
chmod a+w ./pebble.linux
5252

@@ -73,8 +73,8 @@ function prepare_datadir() {
7373
# Build the mkbench tool from within the Pebble repo. This is used to parse
7474
# the benchmark data.
7575
function build_mkbench() {
76-
bazel build @com_github_cockroachdb_pebble//internal/mkbench --config ci -c opt
77-
BAZEL_BIN=$(bazel info bazel-bin --config ci -c opt)
76+
bazel build @com_github_cockroachdb_pebble//internal/mkbench -c opt
77+
BAZEL_BIN=$(bazel info bazel-bin -c opt)
7878
cp $BAZEL_BIN/external/com_github_cockroachdb_pebble/internal/mkbench/mkbench_/mkbench .
7979
chmod a+w mkbench
8080
}

build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic_crossversion_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ ls -l "/test-bin"
1818

1919
echo "TC_SERVER_URL is $TC_SERVER_URL"
2020

21-
bazel build //pkg/cmd/bazci --config=ci
21+
bazel build //pkg/cmd/bazci
2222

23-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
23+
BAZEL_BIN=$(bazel info bazel-bin)
2424

2525
# The script accepts the arguments accepted by TestMetaCrossVersion. It should
2626
# look like:

build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ mkdir -p $ARTIFACTS_DIR
1414

1515
echo "TC_SERVER_URL is $TC_SERVER_URL"
1616

17-
bazel build //pkg/cmd/bazci --config=ci
17+
bazel build //pkg/cmd/bazci
1818

19-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
19+
BAZEL_BIN=$(bazel info bazel-bin)
2020

2121
exit_status=0
2222
# NB: If adjusting the metamorphic test flags below, be sure to also update

build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic_race_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ mkdir -p $ARTIFACTS_DIR
1414

1515
echo "TC_SERVER_URL is $TC_SERVER_URL"
1616

17-
bazel build //pkg/cmd/bazci --config=ci
17+
bazel build //pkg/cmd/bazci
1818

19-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
19+
BAZEL_BIN=$(bazel info bazel-bin)
2020

2121
exit_status=0
2222
# NB: If adjusting the metamorphic test flags below, be sure to also update

build/teamcity/cockroach/nightlies/pebble_nightly_metamorphic_two_instance_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ mkdir -p $ARTIFACTS_DIR
1414

1515
echo "TC_SERVER_URL is $TC_SERVER_URL"
1616

17-
bazel build //pkg/cmd/bazci --config=ci
17+
bazel build //pkg/cmd/bazci
1818

19-
BAZEL_BIN=$(bazel info bazel-bin --config ci)
19+
BAZEL_BIN=$(bazel info bazel-bin)
2020

2121
exit_status=0
2222
# NB: If adjusting the metamorphic test flags below, be sure to also update

build/teamcity/cockroach/nightlies/pebble_nightly_race_common.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ mkdir -p "$PWD/bin"
3333
chmod o+rwx "$PWD/bin"
3434

3535
# Build the roachtest binary.
36-
bazel build //pkg/cmd/roachtest --config ci -c opt
37-
BAZEL_BIN=$(bazel info bazel-bin --config ci -c opt)
36+
bazel build //pkg/cmd/roachtest -c opt
37+
BAZEL_BIN=$(bazel info bazel-bin -c opt)
3838
cp $BAZEL_BIN/pkg/cmd/roachtest/roachtest_/roachtest bin
3939
chmod a+w bin/roachtest
4040

@@ -45,8 +45,8 @@ chmod a+w bin/roachtest
4545
bazel run @go_sdk//:bin/go get github.com/cockroachdb/pebble@master
4646
NEW_DEPS_BZL_CONTENT=$(bazel run //pkg/cmd/mirror/go:mirror)
4747
echo "$NEW_DEPS_BZL_CONTENT" > DEPS.bzl
48-
bazel build @com_github_cockroachdb_pebble//cmd/pebble --config race --config ci -c opt
49-
BAZEL_BIN=$(bazel info bazel-bin --config race --config ci -c opt)
48+
bazel build @com_github_cockroachdb_pebble//cmd/pebble --config race -c opt
49+
BAZEL_BIN=$(bazel info bazel-bin --config race -c opt)
5050
cp $BAZEL_BIN/external/com_github_cockroachdb_pebble/cmd/pebble/pebble_/pebble ./pebble.linux
5151
chmod a+w ./pebble.linux
5252

build/teamcity/cockroach/nightlies/random_syntax_tests_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ set -xeuo pipefail
1010

1111
dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))"
1212

13-
bazel build //pkg/cmd/bazci --config=ci
14-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
13+
bazel build //pkg/cmd/bazci
14+
BAZEL_BIN=$(bazel info bazel-bin)
1515
exit_status=0
1616
$BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci -- test --config=ci \
1717
//pkg/sql/tests:tests_test \

build/teamcity/cockroach/nightlies/roachtest_compile_component.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ esac
116116

117117
echo "Building $os/$arch/$component..."
118118

119-
bazel build --config $config --config ci -c opt "${bazel_args[@]}"
120-
BAZEL_BIN=$(bazel info bazel-bin --config $config --config ci -c opt)
119+
bazel build --config $config -c opt "${bazel_args[@]}"
120+
BAZEL_BIN=$(bazel info bazel-bin --config $config -c opt)
121121
for artifact in "${artifacts[@]}"; do
122122
src=${artifact%%:*}
123123
dst=${artifact#*:}

build/teamcity/cockroach/nightlies/schema_changer_comparator_nightly_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ source "$dir/teamcity-support.sh"
1414
exit_status=0
1515

1616

17-
bazel build //pkg/cmd/bazci --config=ci
18-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
17+
bazel build //pkg/cmd/bazci
18+
BAZEL_BIN=$(bazel info bazel-bin)
1919

2020
# Run schema changer comparator test.
2121
$BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci test -- --config=ci \

build/teamcity/cockroach/nightlies/sqlite_logic_test_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ set -xeuo pipefail
1010

1111
dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))"
1212

13-
bazel build //pkg/cmd/bazci --config=ci
14-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
13+
bazel build //pkg/cmd/bazci
14+
BAZEL_BIN=$(bazel info bazel-bin)
1515
exit_status=0
1616
$BAZEL_BIN/pkg/cmd/bazci/bazci_/bazci -- test --config=ci \
1717
//pkg/sql/sqlitelogictest/tests/... \

build/teamcity/cockroach/nightlies/sqllogic_backup_restore_impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ dir="$(dirname $(dirname $(dirname $(dirname "${0}"))))"
1212
source "$dir/teamcity-bazel-support.sh" # For process_test_json
1313
source "$dir/teamcity-support.sh"
1414

15-
bazel build //pkg/cmd/bazci --config=ci
16-
BAZEL_BIN=$(bazel info bazel-bin --config=ci)
15+
bazel build //pkg/cmd/bazci
16+
BAZEL_BIN=$(bazel info bazel-bin)
1717
google_credentials="$GOOGLE_EPHEMERAL_CREDENTIALS"
1818

1919
log_into_gcloud

0 commit comments

Comments
 (0)