Skip to content

Commit 9ba3a52

Browse files
committed
build: upgrade to go 1.23.7
* [ ] Adjust the Pebble tests to run in new version. * [ ] Update [our `go` fork](https://github.com/cockroachdb/go) with a new branch containing our patches. Create a new branch `cockroach-go$GO_VERSION` and take note of the commit ID. * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/commit.txt` with the commit ID in the `go` fork. * [ ] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new `GOVERS` and adjust SHA256 sums as necessary. * [ ] Adjust `GO_FIPS_COMMIT` for the FIPS Go toolchain ([source](./teamcity/internal/release/build-and-publish-patched-go/impl-fips.sh)). * [ ] Run the `Internal / Cockroach / Build / Toolchains / Publish Patched Go for Mac` build configuration in TeamCity with your latest version of the script above. Note the job depends on another job `Build and Publish Patched Go`. That job prints out the SHA256 of all tarballs, which you will need to copy-paste into `WORKSPACE` (see below). `Publish Patched Go for Mac` is an extra step that publishes the *signed* `go` binaries for macOS. That job also prints out the SHA256 of the Mac tarballs in particular. * [ ] Adjust `--@io_bazel_rules_go//go/toolchain:sdk_version` in [.bazelrc](../.bazelrc). * [ ] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above. * [ ] Bump the version in `WORKSPACE` under `go_download_sdk` for the FIPS version of Go (`go_sdk_fips`). * [ ] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value. * [ ] Bump the go version in `go.mod`. * [ ] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [ ] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). Epic: none Release note: Update to Go 1.23.7
1 parent 2acfe9a commit 9ba3a52

File tree

8 files changed

+26
-26
lines changed

8 files changed

+26
-26
lines changed

.bazelrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ build:crosslinuxfips '--workspace_status_command=./build/bazelutil/stamp.sh x86_
8787
build:crosslinuxfips --config=crosslinuxfipsbase
8888
build:crosslinuxfipsbase --platforms=//build/toolchains:cross_linux
8989
build:crosslinuxfipsbase --config=cross
90-
build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.23.6fips
90+
build:crosslinuxfipsbase --@io_bazel_rules_go//go/toolchain:sdk_version=1.23.7fips
9191
build:crosswindows '--workspace_status_command=./build/bazelutil/stamp.sh x86_64-w64-mingw32'
9292
build:crosswindows --config=crosswindowsbase
9393
build:crosswindowsbase --platforms=//build/toolchains:cross_windows

WORKSPACE

+11-11
Original file line numberDiff line numberDiff line change
@@ -167,15 +167,15 @@ load(
167167
go_download_sdk(
168168
name = "go_sdk",
169169
sdks = {
170-
"darwin_amd64": ("go1.23.6.darwin-amd64.tar.gz", "8d5656e3a674997e27d55fdedb1283fd47d12dee0c040fb2468e6ccfc5229b2b"),
171-
"darwin_arm64": ("go1.23.6.darwin-arm64.tar.gz", "461e2f9826e947a668331e98cec7e176faae97c65da2fa1a048136fdc5e25b6e"),
172-
"linux_amd64": ("go1.23.6.linux-amd64.tar.gz", "c1a4f4a6d77f3a8d0605b274019c10f281a26a70019f5e62de3722ec2e27d3f7"),
173-
"linux_arm64": ("go1.23.6.linux-arm64.tar.gz", "01efad79ef61c8ae3fe2c330f539fb8e30bd4b61c15dc23f4bc6e4fae499aa27"),
174-
"linux_s390x": ("go1.23.6.linux-s390x.tar.gz", "3a486d1916871b329cf2ca8fe95afe4ebf8c5f655c7fa9dd46fd8ecfdf2499ca"),
175-
"windows_amd64": ("go1.23.6.windows-amd64.tar.gz", "936455995b7bbc64190c12db3da31a3951775e26d15fd3987333f34c2478087e"),
170+
"darwin_amd64": ("go1.23.7.darwin-amd64.tar.gz", "76497c55ad59457091c6dd04ae33977254d38283e53ee2d6bc0b7d777239d34e"),
171+
"darwin_arm64": ("go1.23.7.darwin-arm64.tar.gz", "f661c23425d7667f566590e9ac77939b3b63e30d1a10675ca81ac5e4b3414987"),
172+
"linux_amd64": ("go1.23.7.linux-amd64.tar.gz", "f9baea5264009b0b07613964cee8bc861301eb730726f1022a81f299505d3f40"),
173+
"linux_arm64": ("go1.23.7.linux-arm64.tar.gz", "bcbcee8da9f3b47637f05b097ea3901b47800d49d91c451f2fa815156b43ad50"),
174+
"linux_s390x": ("go1.23.7.linux-s390x.tar.gz", "26d2ae0a1df1f378d189943d4a916ac1999beb49703996145fd7392fc0afadbe"),
175+
"windows_amd64": ("go1.23.7.windows-amd64.tar.gz", "9f1a6efca4717d426675065d92471afa1a3e5dc707f0a1f659dac29207f3b01c"),
176176
},
177-
urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/{}"],
178-
version = "1.23.6",
177+
urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/{}"],
178+
version = "1.23.7",
179179
)
180180

181181
# To point to a local SDK path, use the following instead. We'll call the
@@ -660,8 +660,8 @@ go_download_sdk(
660660
# able to provide additional diagnostic information such as the expected version of OpenSSL.
661661
experiments = ["boringcrypto"],
662662
sdks = {
663-
"linux_amd64": ("go1.23.6fips.linux-amd64.tar.gz", "fb7e0eaa3ee0dbdb94de61ca7d761f6f436719ec0a63f5850dc14de880ef0f37"),
663+
"linux_amd64": ("go1.23.7fips.linux-amd64.tar.gz", "b8e942eb06ec19db5e2ee8fa276b0df8a9a9bd97b081d349f331c8f06f27cb55"),
664664
},
665-
urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/{}"],
666-
version = "1.23.6fips",
665+
urls = ["https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/{}"],
666+
version = "1.23.7fips",
667667
)

build/bazelutil/distdir_files.bzl

+7-7
Original file line numberDiff line numberDiff line change
@@ -1245,13 +1245,13 @@ DISTDIR_FILES = {
12451245
"https://storage.googleapis.com/public-bazel-artifacts/c-deps/20241202-211651/libproj_foreign.macos.20241202-211651.tar.gz": "b0a672f24748c24c941884c04413fd8e20afd6bca95e0451f3cfb15dd2cc1eb9",
12461246
"https://storage.googleapis.com/public-bazel-artifacts/c-deps/20241202-211651/libproj_foreign.macosarm.20241202-211651.tar.gz": "a35706bf0112e9652d6e41501113ee0f0f392b67e495979c867f71f17cf6ce7e",
12471247
"https://storage.googleapis.com/public-bazel-artifacts/c-deps/20241202-211651/libproj_foreign.windows.20241202-211651.tar.gz": "a33b64a784e856dbb3c84a52075227c48f0ff52a858639c3737a8911201d0c65",
1248-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.darwin-amd64.tar.gz": "8d5656e3a674997e27d55fdedb1283fd47d12dee0c040fb2468e6ccfc5229b2b",
1249-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.darwin-arm64.tar.gz": "461e2f9826e947a668331e98cec7e176faae97c65da2fa1a048136fdc5e25b6e",
1250-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.linux-amd64.tar.gz": "c1a4f4a6d77f3a8d0605b274019c10f281a26a70019f5e62de3722ec2e27d3f7",
1251-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.linux-arm64.tar.gz": "01efad79ef61c8ae3fe2c330f539fb8e30bd4b61c15dc23f4bc6e4fae499aa27",
1252-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.linux-s390x.tar.gz": "3a486d1916871b329cf2ca8fe95afe4ebf8c5f655c7fa9dd46fd8ecfdf2499ca",
1253-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6.windows-amd64.tar.gz": "936455995b7bbc64190c12db3da31a3951775e26d15fd3987333f34c2478087e",
1254-
"https://storage.googleapis.com/public-bazel-artifacts/go/20250227-181556/go1.23.6fips.linux-amd64.tar.gz": "fb7e0eaa3ee0dbdb94de61ca7d761f6f436719ec0a63f5850dc14de880ef0f37",
1248+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.darwin-amd64.tar.gz": "76497c55ad59457091c6dd04ae33977254d38283e53ee2d6bc0b7d777239d34e",
1249+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.darwin-arm64.tar.gz": "f661c23425d7667f566590e9ac77939b3b63e30d1a10675ca81ac5e4b3414987",
1250+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.linux-amd64.tar.gz": "f9baea5264009b0b07613964cee8bc861301eb730726f1022a81f299505d3f40",
1251+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.linux-arm64.tar.gz": "bcbcee8da9f3b47637f05b097ea3901b47800d49d91c451f2fa815156b43ad50",
1252+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.linux-s390x.tar.gz": "26d2ae0a1df1f378d189943d4a916ac1999beb49703996145fd7392fc0afadbe",
1253+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7.windows-amd64.tar.gz": "9f1a6efca4717d426675065d92471afa1a3e5dc707f0a1f659dac29207f3b01c",
1254+
"https://storage.googleapis.com/public-bazel-artifacts/go/20250312-000108/go1.23.7fips.linux-amd64.tar.gz": "b8e942eb06ec19db5e2ee8fa276b0df8a9a9bd97b081d349f331c8f06f27cb55",
12551255
"https://storage.googleapis.com/public-bazel-artifacts/java/railroad/rr-1.63-java8.zip": "d2791cd7a44ea5be862f33f5a9b3d40aaad9858455828ebade7007ad7113fb41",
12561256
"https://storage.googleapis.com/public-bazel-artifacts/js/rules_jest-v0.18.4.tar.gz": "d3bb833f74b8ad054e6bff5e41606ff10a62880cc99e4d480f4bdfa70add1ba7",
12571257
"https://storage.googleapis.com/public-bazel-artifacts/js/rules_js-v1.42.3.tar.gz": "2cfb3875e1231cefd3fada6774f2c0c5a99db0070e0e48ea398acbff7c6c765b",

build/bootstrap/bootstrap-debian.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ sudo tar -C /usr --strip-components=1 -zxf /tmp/cmake.tgz && rm /tmp/cmake.tgz
4545

4646
# Install Go.
4747
trap 'rm -f /tmp/go.tgz' EXIT
48-
curl -fsSL https://dl.google.com/go/go1.23.6.linux-amd64.tar.gz >/tmp/go.tgz
48+
curl -fsSL https://dl.google.com/go/go1.23.7.linux-amd64.tar.gz >/tmp/go.tgz
4949
sha256sum -c - <<EOF
50-
9379441ea310de000f33a4dc767bd966e72ab2826270e038e78b2c53c2e7802d /tmp/go.tgz
50+
4741525e69841f2e22f9992af25df0c1112b07501f61f741c12c6389fcb119f3 /tmp/go.tgz
5151
EOF
5252
sudo tar -C /usr/local -zxf /tmp/go.tgz && rm /tmp/go.tgz
5353

Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ae89cf02df7a088c1f36752c0a31bfbc6a5eb5bd
1+
873d6bf8a684b29c8ab932bd6e1b7e6cdcf6f99b

build/teamcity/internal/release/build-and-publish-patched-go/impl.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
set -xeuo pipefail
1010

1111
# When updating to a new Go version, update all of these variables.
12-
GOVERS=1.23.6
12+
GOVERS=1.23.7
1313
GOCOMMIT=$(grep -v ^# /bootstrap/commit.txt | head -n1)
1414
# We use this for bootstrapping (this is NOT re-published). Note the version
1515
# matches the version we're publishing, although it doesn't technically have to.
1616
GOLINUXLINK=https://go.dev/dl/go$GOVERS.linux-amd64.tar.gz
17-
LINUXSHASUM=9379441ea310de000f33a4dc767bd966e72ab2826270e038e78b2c53c2e7802d
17+
LINUXSHASUM=4741525e69841f2e22f9992af25df0c1112b07501f61f741c12c6389fcb119f3
1818
1919
apt-get update
2020
DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/cockroachdb/cockroach
22

3-
go 1.23.6
3+
go 1.23.7
44

55
// golang.org/x/* packages are maintained and curated by the go project, just
66
// without the backwards compatibility promises the standard library, and thus

pkg/cmd/roachtest/tests/cdc.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -3765,7 +3765,7 @@ const createMSKTopicBinPath = "/tmp/create-msk-topic"
37653765
var setupMskTopicScript = fmt.Sprintf(`
37663766
#!/bin/bash
37673767
set -e -o pipefail
3768-
wget https://go.dev/dl/go1.23.6.linux-amd64.tar.gz -O /tmp/go.tar.gz
3768+
wget https://go.dev/dl/go1.23.7.linux-amd64.tar.gz -O /tmp/go.tar.gz
37693769
sudo rm -rf /usr/local/go
37703770
sudo tar -C /usr/local -xzf /tmp/go.tar.gz
37713771
echo export PATH=$PATH:/usr/local/go/bin >> ~/.profile

0 commit comments

Comments
 (0)