Remove .ruby-version. (#174)

* This isn't necessary... Removing.

Everything is in a docker container and running on 2.3 anyways.

* Update rubocop config

- Pull in remote styleguide configuration
- Sets target ruby version to 2.3

* Fix CC issues

Author: zenspider

.codeclimate.yml

@@ -1,4 +1,8 @@
 ---
+prepare:
+  fetch:
+    - url: https://raw.githubusercontent.com/codeclimate/styleguide/master/ruby/rubocop.yml
+      path: base_rubocop.yml
 engines:
   rubocop:
     enabled: true

.gitignore

@@ -1 +1,2 @@
+base_rubocop.yml
 node_modules

.rubocop.yml

@@ -1,152 +1,4 @@
-################################################################################
-# Metrics
-################################################################################
+inherit_from: base_rubocop.yml
 
-Metrics/LineLength:
-  Enabled: false
-
-Metrics/AbcSize:
-  Enabled: false
-
-################################################################################
-# Style
-################################################################################
-
-# Executables are conventionally named bin/foo-bar
-Style/FileName:
-  Exclude:
-  - bin/**/*
-
-# We don't (currently) document our code
-Style/Documentation:
-  Enabled: false
-
-# Always use double-quotes to keep things simple
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-
-Style/StringLiteralsInInterpolation:
-  EnforcedStyle: double_quotes
-
-# Use a trailing comma to keep diffs clean when elements are inserted or removed
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: comma
-
-# We avoid GuardClause because it can result in "suprise return"
-Style/GuardClause:
-  Enabled: false
-
-# We avoid IfUnlessModifier because it can result in "suprise if"
-Style/IfUnlessModifier:
-  Enabled: false
-
-# We don't care about the fail/raise distinction
-Style/SignalException:
-  EnforcedStyle: only_raise
-
-Style/DotPosition:
-  EnforcedStyle: trailing
-
-# Common globals we allow
-Style/GlobalVars:
-  AllowedVariables:
-  - "$statsd"
-  - "$mongo"
-  - "$rollout"
-
-# Using english names requires loading an extra module, which is annoying, so
-# we prefer the perl names for consistency.
-Style/SpecialGlobalVars:
-  EnforcedStyle: use_perl_names
-
-# We have common cases where has_ and have_ make sense
-Style/PredicateName:
-  Enabled: true
-  NamePrefixBlacklist:
-  - is_
-
-# We use %w[ ], not %w( ) because the former looks like an array
-Style/PercentLiteralDelimiters:
-  PreferredDelimiters:
-    "%i": "[]"
-    "%I": "[]"
-    "%w": "[]"
-    "%W": "[]"
-
-# Allow "trivial" accessors when defined as a predicate? method
-Style/TrivialAccessors:
-  AllowPredicates: true
-
-Style/Next:
-  Enabled: false
-
-# We think it's OK to use the "extend self" module pattern
-Style/ModuleFunction:
-  Enabled: false
-
-# Disallow extra spacing for token alignment
-Style/ExtraSpacing:
-  AllowForAlignment: false
-
-# and/or in conditionals has no meaningful difference (only gotchas), so we
-# disallow them there. When used for control flow, the difference in precedence
-# can make for a less noisy expression, as in:
-#
-#   x = find_x or raise XNotFound
-#
-Style/AndOr:
-  EnforcedStyle: conditionals
-
-Style/AlignParameters:
-  EnforcedStyle: with_fixed_indentation
-
-Style/MultilineOperationIndentation:
-  EnforcedStyle: indented
-
-Style/AlignHash:
-  EnforcedLastArgumentHashStyle: ignore_implicit
-
-# This has the behavior we want, but it has a bug in it which produces a lot of false positives
-# https://github.com/bbatsov/rubocop/issues/3462
-# MultilineMethodCallBraceLayout:
-#   EnforcedStyle: new_line
-
-################################################################################
-# Performance
-################################################################################
-
-Performance/RedundantMerge:
-  Enabled: false
-
-################################################################################
-# Rails - disable things because we're primarily non-rails
-################################################################################
-
-Rails/Delegate:
-  Enabled: false
-
-Rails/TimeZone:
-  Enabled: false
-
-################################################################################
-# Specs - be more lenient on length checks and block styles
-################################################################################
-
-Metrics/ModuleLength:
-  Exclude:
-  - spec/**/*
-
-Metrics/MethodLength:
-  Exclude:
-  - spec/**/*
-
-Style/ClassAndModuleChildren:
-  Exclude:
-  - spec/**/*
-
-Style/BlockDelimiters:
-  Exclude:
-  - spec/**/*
+AllCops:
+  TargetRubyVersion: 2.3

.ruby-version

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source "https://rubygems.org"
 
 gem "concurrent-ruby", "~> 1.0.0"

Gemfile

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 begin
-  require 'rspec/core/rake_task'
+  require "rspec/core/rake_task"
   RSpec::Core::RakeTask.new(:spec)
 
-  task :default => :spec
+  task default: :spec
 rescue LoadError
 end

Rakefile

@@ -1,13 +1,15 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 $:.unshift(File.expand_path(File.join(File.dirname(__FILE__), "../lib")))
 require "cc/engine/duplication"
 
-if File.exists?("/config.json")
-  engine_config = JSON.parse(File.read("/config.json"))
-else
-  engine_config = {}
-end
+engine_config =
+  if File.exist?("/config.json")
+    JSON.parse(File.read("/config.json"))
+  else
+    {}
+  end
 
 directory = ARGV[0] || "/code"
 

bin/duplication

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "cc/engine/analyzers/parser_error"
 require "cc/engine/analyzers/parser_base"
 
@@ -67,8 +69,8 @@ def points_per_overage
           self.class::POINTS_PER_OVERAGE
         end
 
-        def process_file(path)
-          raise NoMethodError.new("Subclass must implement `process_file`")
+        def process_file(_path)
+          raise NoMethodError, "Subclass must implement `process_file`"
         end
 
         def file_list

lib/cc/engine/analyzers/analyzer_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "open3"
 require "timeout"
 
@@ -52,4 +54,3 @@ def success?
     end
   end
 end
-

lib/cc/engine/analyzers/command_line_runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     module Analyzers
@@ -45,8 +47,8 @@ def count_threshold_for(language)
 
         def fetch_language(language)
           language = config.
-            fetch("languages", {}).
-            fetch(language, {})
+                     fetch("languages", {}).
+                     fetch(language, {})
 
           if language.is_a? Hash
             language

lib/cc/engine/analyzers/engine_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "pathname"
 
 module CC

lib/cc/engine/analyzers/file_list.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "thread"
 
 module CC
@@ -12,7 +14,7 @@ def initialize(files, concurrency: DEFAULT_CONCURRENCY)
           @concurrency = concurrency
         end
 
-        def run(&block)
+        def run
           queue = build_queue
           lock = Mutex.new
 
@@ -46,7 +48,7 @@ def build_queue
         end
 
         def thread_count
-          if (1..MAX_CONCURRENCY) === concurrency
+          if (1..MAX_CONCURRENCY).cover?(concurrency)
             concurrency
           elsif concurrency < 1
             DEFAULT_CONCURRENCY

lib/cc/engine/analyzers/file_thread_pool.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "cc/engine/analyzers/analyzer_base"
 require "cc/engine/analyzers/javascript/parser"
 require "cc/engine/analyzers/javascript/minification_checker"

lib/cc/engine/analyzers/javascript/main.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     module Analyzers

lib/cc/engine/analyzers/javascript/minification_checker.rb

@@ -1,11 +1,13 @@
-require 'cc/engine/analyzers/node'
+# frozen_string_literal: true
+
+require "cc/engine/analyzers/node"
 
 module CC
   module Engine
     module Analyzers
       module Javascript
         class Node < CC::Engine::Analyzers::Node
-          SCRUB_PROPERTIES = %w[type start end]
+          SCRUB_PROPERTIES = %w[type start end].freeze
 
           private
 

lib/cc/engine/analyzers/javascript/node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "cc/engine/analyzers/command_line_runner"
 
 module CC
@@ -24,12 +26,12 @@ def parse
           private
 
           def js_command
-            file = File.expand_path(File.dirname(__FILE__)) + '/parser.js'
+            file = File.expand_path(File.dirname(__FILE__)) + "/parser.js"
             "node #{file}"
           end
 
           def strip_shebang(code)
-            if code.start_with?('#!')
+            if code.start_with?("#!")
               code.lines.drop(1).join
             else
               code

lib/cc/engine/analyzers/javascript/parser.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     module Analyzers
       class Node
-        SCRUB_PROPERTIES = []
+        SCRUB_PROPERTIES = [].freeze
 
         def initialize(node, file, default_line = 0)
           @node = node
@@ -42,7 +44,7 @@ def properties_to_sexps
           valid_properties.map do |key, value|
             if value.is_a?(Array)
               create_sexp(key.to_sym, *self.class.new(value, @file, @line).format)
-            elsif  value.is_a?(Hash)
+            elsif value.is_a?(Hash)
               create_sexp(key.to_sym, self.class.new(value, @file, @line).format)
             else
               value.to_s.to_sym

lib/cc/engine/analyzers/node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     module Analyzers

lib/cc/engine/analyzers/parser_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module CC
   module Engine
     module Analyzers

lib/cc/engine/analyzers/parser_error.rb

@@ -1,4 +1,6 @@
-require 'cc/engine/analyzers/php/nodes'
+# frozen_string_literal: true
+
+require "cc/engine/analyzers/php/nodes"
 
 module CC
   module Engine
@@ -24,8 +26,8 @@ def self.json_to_ast(ast, filename)
             }
             if (node_type = ast.delete("nodeType"))
               node_attrs[:node_type] = node_type.
-                  sub(prefix_re, '').
-                  sub(suffix_re, '')
+                                       sub(prefix_re, "").
+                                       sub(suffix_re, "")
             end
             ast.each do |key, value|
               unless key == "nodeAttributes"