Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Push API #132

Open
tomtaylor opened this issue Oct 2, 2018 · 2 comments
Open

Web Push API #132

tomtaylor opened this issue Oct 2, 2018 · 2 comments

Comments

@tomtaylor
Copy link

Is there any interest in adding support for the Web Push API? I could probably find some time to work on it, if there was support for adding this to Pigeon.
@hpopp
Copy link
Member

hpopp commented Oct 3, 2018

Definitely interest, but I haven't had the time to properly plan it out. Pigeon is currently using the legacy FCM API, which would mean web push should also use legacy. That said, I'm planning to migrate everything to the new FCM API in Pigeon v2.0, so a lot of this work feels redundant.

It's probably best to go ahead and implement the legacy API now. By all means open up a PR if you want to work on it.

@hpopp
Copy link
Member

hpopp commented Oct 3, 2018

Eheh, after doing some reading, disregard everything I said. I didn't realize FCM implements the web push protocol.

By all means go ahead and work on it! I'm envisioning a new Pigeon.Web with all the related submodules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomtaylor @hpopp