Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop button is still rendered after the workspace was stopped #12

Closed
fioan89 opened this issue Mar 3, 2025 · 4 comments · Fixed by #23
Closed

Stop button is still rendered after the workspace was stopped #12

fioan89 opened this issue Mar 3, 2025 · 4 comments · Fixed by #23
Milestone
Toolbox launch

Comments

@fioan89
Copy link
Collaborator

fioan89 commented Mar 3, 2025

Steps to reproduce:

  1. On a running workspace, press the Stop button either from the quick actions button or from the pop-up menu
  2. wait for the workspace to stop.
  3. Stop action button is still enabled while Start button is disabled.

Image

Image
@matifali
Copy link
Member

matifali commented Mar 7, 2025

Seems solved for me on #20

Image

@matifali
Copy link
Member

matifali commented Mar 7, 2025

Although the Updates keep showing after I hit Update

Image

@matifali
Copy link
Member

matifali commented Mar 7, 2025

Quitting and restarting Toolbox disables the Update action.

@fioan89
Copy link
Collaborator Author

fioan89 commented Mar 7, 2025

Weird, I can still reproduce it with the latest code. I'll investigate this. BTW it makes sense for the action buttons to have a correct state after Toolbox restart because they were freshly initialized with data from backend.

Image

Image

fioan89 added a commit that referenced this issue Mar 7, 2025
@fioan89
fix: env. action buttons state
d553636 
- the action buttons like (start/stop/update) did not change visibility or enabled property when
  the workspace changed its running status
- this fix regenerates the list of available actions in order to force a re-draw in UI when workspace status changes
- resolves #12
@fioan89 fioan89 mentioned this issue Mar 7, 2025
Merged
@fioan89 fioan89 closed this as completed in 2a9f5e1 Mar 8, 2025
@matifali matifali added this to the v0.1.0 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Toolbox launch
Development

Successfully merging a pull request may close this issue.

fix: env. action buttons state coder/coder-jetbrains-toolbox
2 participants
@fioan89 @matifali