Coder settings are not taken into account #40
Milestone
Comments
fioan89
added a commit
that referenced
this issue
Mar 26, 2025
- too much confusion around CoderSettings, CoderSettingsState, CoderSettingsService - lots of properties and some models were introduced only to inject data during tests - test related properties were leaking in the business code and there was no clear definition between the readable and writable interface - with this commit we have CoderSettingsStore exposing read+write, CoderSettings exposing reads + PluginSettingsStore the underlying persistable store - the tests control data via an instance of PluginSettingsStore just like the business code - two settings are now also exposed and configurable in the UI (previously only from tests): - ssh log dir - ssh extra arguments to the proxy command - resolves #40 - some of the options that did not make sense to be configurable and were only used in the tests were removed: - setupCommand - ignoreSetupFailures - these two are Gateway specific
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have this page that allows various configuration while in the code there are many settings remnant from Coder Gateway plugin. We should be revisited and removed all unused settings.
The text was updated successfully, but these errors were encountered: