Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token input screen is closed after I closed Toolbox popup to copy token in browser #45

Closed
matifali opened this issue Mar 26, 2025 — with Slack · 0 comments · Fixed by #72
Closed

token input screen is closed after I closed Toolbox popup to copy token in browser #45

matifali opened this issue Mar 26, 2025 — with Slack · 0 comments · Fixed by #72
Assignees

Comments

Copy link
Member

The screen where I need to put the token is closed after I closed Toolbox popup to copy token in browser

Slack Message

@matifali matifali added this to the v0.1.0 milestone Mar 26, 2025 — with Slack
@matifali matifali added upstream Issues awaiting an upstream issue and removed upstream Issues awaiting an upstream issue labels Apr 2, 2025
fioan89 added a commit that referenced this issue Apr 7, 2025
… browser

- rough draft to fix UI state management in the authentication flow which today has 3 pages. If user closes
  Toolbox in any of these three pages (for example to go and copy the token from a browser), then when it comes back in Toolbox does not remember which was the last visible UiPage.
- until JetBrains improves Toolbox state management, we can work around the problem by having only one
  UiPage with three "steps" in it, similar to a wizard. With this approach we can have complete control over
  the state of the page.

- to be noted that I've also looked over two other approaches. The first idea was to manage the stat
  ourselves, but that didn’t work out as Toolbox doesn’t clearly tell us when the user clicks the Back
  button vs. when they close the window. So we can’t reliably figure out which page to show when it reopens.
- another option was changing the auth flow entirely and adding custom redirect URLs for Toolbox plugins.
  But that would only work with certain Coder versions, which might not be ideal.

- resolves #45
@fioan89 fioan89 closed this as completed in 4c68440 Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants