From 0fd8840468a7cfbae1b8ec98910044cc856e000c Mon Sep 17 00:00:00 2001
From: Faur Ioan-Aurel <fioan89@gmail.com>
Date: Tue, 11 Mar 2025 01:15:44 +0200
Subject: [PATCH] fix: simplify build and draft release jobs

- and also fix the zip and release notes publish
- there is no need to unzip and then later re-zip files to be published as draft
  because Kotlin does the zip in the first place, we just need to upload it
  and download it in the jobs that need it.
- similar, release note files have to be shared between jobs by upload&download
---
 .github/workflows/build.yml | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ecb4f5f..8a55c79 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -77,22 +77,18 @@ jobs:
       - name: Run Build
         run: ./gradlew clean pluginZip --info
 
-      # Prepare plugin archive content for creating artifact
-      - name: Prepare Plugin Artifact
-        id: artifact
-        shell: bash
-        run: |
-          cd ${{ github.workspace }}/build/distributions
-          FILENAME=$(ls *.zip)
-          unzip "$FILENAME" -d content
-          echo "filename=${FILENAME:0:-4}" >> $GITHUB_OUTPUT
-
       # Store already-built plugin as an artifact for downloading
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ steps.artifact.outputs.filename }}
-          path: ./build/distributions/content/*/*
+          name: zip-artifacts
+          path: ./build/distributions/*.zip
+
+      - name: Upload Release Notes
+        uses: actions/upload-artifact@v4
+        with:
+          name: release-notes
+          path: RELEASE_NOTES.md
 
   # Prepare a draft release for GitHub Releases page for the manual verification
   # If accepted and published, release workflow would be triggered
@@ -119,8 +115,16 @@ jobs:
       - name: Download Build Artifacts
         uses: actions/download-artifact@v4
         with:
-          name: release-artifacts
+          name: zip-artifacts
           path: artifacts/
+      - name: Display the Zip files that are going to be attached
+        run: ls -R artifacts/
+
+      - name: Download Release Notes
+        uses: actions/download-artifact@v4
+        with:
+          name: release-notes
+          path: notes/
 
       # Create new release draft - which is not publicly visible and requires manual acceptance
       - name: Create Release Draft
@@ -131,4 +135,4 @@ jobs:
             --draft artifacts/* \
             --target ${GITHUB_REF_NAME} \
             --title "v${{ needs.build.outputs.version }}" \
-            --notes-file RELEASE_NOTES.md
+            --notes-file notes/RELEASE_NOTES.md