Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debuggin' to the plugin #429

Closed
3 tasks
Kira-Pilot opened this issue Jan 27, 2025 · 2 comments
Closed
3 tasks

Add debuggin' to the plugin #429

Kira-Pilot opened this issue Jan 27, 2025 · 2 comments

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jan 27, 2025

Recently we have been investigating a hard-to-reproduce integrated terminal latency issue. We should introduce some logging and diagnostics into the plugin so we can provide a build to the affected user and glean more information:

  • add centralized logger (if there isn't one already)
  • add debug calls to thorny areas of code as identified in our walkthrough, as well as to lifecycle events
  • provide user with a debug build

Logging Ideas:
https://github.com/coder/vscode-coder/blob/main/src/remote.ts#L745
Is polling continuing indefinitely here?

https://github.com/coder/vscode-coder/blob/main/src/remote.ts#L785
are repeated file reads here slowing down performance?

https://github.com/coder/coder/blob/main/cli/vscodessh.go#L33
anything weird going on in here? This is the Go code on the Coder side. We wouldn't add logging here but might consider this interface on the plugin side considering VS Code is reading from it continuously to display connection info via a callback.
https://github.com/coder/coder/blob/main/cli/vscodessh.go#L199

We might want to log memory usage over time to see if we find any jump.

@bcpeinhardt
Copy link
Collaborator

There is a centralized logger, and a dedicated output channel for the extension which we write to. I think a further thing we could provide is a "Support.md" file, with instructions on what debugging/troubleshooting tools we provide and how to collect information for CS. Ideally any part of that process that can be scripted should be.

@f0ssel
Copy link
Contributor

f0ssel commented Feb 10, 2025

Some ideas:

  • Ask if they can upgrade in staging to new version that uses coder ssh over coder vscoderssh
  • Investigate SSH processes on the machine when things are good vs slow
  • Investigate vscode log dumps locations and coder ssh log dumps
  • Possibly looking at network logs with a netgru person

@f0ssel f0ssel added the must-do label Feb 27, 2025
@matifali matifali marked this as a duplicate of #165 Mar 18, 2025
@Kira-Pilot Kira-Pilot changed the title Add debugging to the plugin Add debuggin' to the plugin Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants