Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE connections leaked #468

Open
spikecurtis opened this issue Apr 3, 2025 · 0 comments
Open

SSE connections leaked #468

spikecurtis opened this issue Apr 3, 2025 · 0 comments
Assignees
Labels
customer-reported regression Something that used to work and is now broken

Comments

@spikecurtis
Copy link

spikecurtis commented Apr 3, 2025

We leak SSE connections to /api/v2/workspaceagents/{id}/watch-metadata in at least the following scenarios, since v1.4.2.

  • A workspace is restarted while the IDE plugin is tracking it
  • You sign into a different Coder deployment with some workspaces running

I have a strong suspicion that #440 is involved, although possibly not the root cause.

Likely the cause of https://github.com/coder/customers/issues/741

How to reproduce

  1. Connect to a Coder server as a user running at least one workspace.
  2. Monitor the coderd_api_concurrent_requests gauge via the Prometheus endpoint on Coder server.

Either:

  1. Repeatedly stop and start the workspace
  2. Repeatedly sign into a different Coder deployment and then back into your test deployment

Then:

  1. Observer the concurrent requests guage climb with each cycle
  2. Exit VSCode, and see it drop.
@spikecurtis spikecurtis added customer-reported regression Something that used to work and is now broken labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported regression Something that used to work and is now broken
Projects
None yet
Development

No branches or pull requests

2 participants