Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header element not yet available when using amd and angular #5

Open
micahblu opened this issue Sep 16, 2015 · 0 comments
Open

header element not yet available when using amd and angular #5

micahblu opened this issue Sep 16, 2015 · 0 comments

Comments

@micahblu
Copy link

The header is queried before angular appends the directive html to the dom, this could be circumvented with a quick check of the header var in the page scroll function and a re-query if necessary. like so:

header = header || document.querySelector( '.cbp-af-header' );

Not sure if this issue is common enough for you guys to make the change but if you'd like I could submit a pr with the fix, it would help me not have to re write the fix when I update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant