Skip to content

Commit de03f4d

Browse files
SkrillexVo Minh Thu
Skrillex
authored and
Vo Minh Thu
committed
[REM] netrpc: KILL EVERYBODY
bzr revid: [email protected]
1 parent a961e5e commit de03f4d

File tree

8 files changed

+9
-34
lines changed

8 files changed

+9
-34
lines changed

debian/control

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ Description: OpenERP Enterprise Resource Management
5252
features are accounting (analytic and financial), stock management, sales and
5353
purchases management, tasks automation, marketing campaigns, help desk, POS,
5454
etc. Technical features include a distributed server, flexible workflows, an
55-
object database, a dynamic GUI, customizable reports, and NET-RPC and XML-RPC
56-
interfaces.
55+
object database, a dynamic GUI, customizable reports, and an XML-RPC
56+
interface.
5757

doc/01_getting_started.rst

-3
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,6 @@ General Options
103103
--logfile=LOGFILE file where the server log will be stored
104104
-n INTERFACE, --interface=INTERFACE specify the TCP IP address
105105
-p PORT, --port=PORT specify the TCP port
106-
--net_interface=NETINTERFACE specify the TCP IP address for netrpc
107-
--net_port=NETPORT specify the TCP port for netrpc
108-
--no-netrpc disable netrpc
109106
--no-xmlrpc disable xmlrpc
110107
-i INIT, --init=INIT init a module (use "all" for all modules)
111108
--without-demo=WITHOUT_DEMO load demo data for a module (use "all" for all modules)

doc/changelog.rst

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Changelog
66
`trunk`
77
-------
88

9+
- Removed support for the ``NET-RPC`` protocol.
910
- Added the :ref:`Long polling <longpolling-worker>` worker type.
1011
- Added :ref:`orm-workflows` to the ORM.
1112
- Added :ref:`routing-decorators` to the RPC and WSGI stack.

install/openerp-server.1

-11
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,6 @@ specify the certificate file for the SSL connection
8080
\fB\-\-pkey\-file\fR=\fISECURE_PKEY_FILE\fR
8181
specify the private key file for the SSL connection
8282
.IP
83-
NET\-RPC Configuration:
84-
.TP
85-
\fB\-\-netrpc\-interface\fR=\fINETRPC_INTERFACE\fR
86-
specify the TCP IP address for the NETRPC protocol
87-
.TP
88-
\fB\-\-netrpc\-port\fR=\fINETRPC_PORT\fR
89-
specify the TCP port for the NETRPC protocol
90-
.TP
91-
\fB\-\-no\-netrpc\fR
92-
disable the NETRPC protocol
93-
.IP
9483
Static HTTP service:
9584
.TP
9685
\fB\-\-static\-http\-enable\fR

openerp/PKG-INFO

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ Description: OpenERP is a complete ERP and CRM. The main features are accounting
1313
and financial), stock management, sales and purchases management, tasks
1414
automation, marketing campaigns, help desk, POS, etc. Technical features include
1515
a distributed server, flexible workflows, an object database, a dynamic GUI,
16-
customizable reports, and NET-RPC and XML-RPC interfaces.
16+
customizable reports, and an XML-RPC interface.
1717
Keywords: ERP, Accounting, Stock, CRM, Enterprise, Logistics, Management, Sales, Purchases
1818
Platform: Linux, Win32

openerp/netsvc.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ def log(logger, level, prefix, msg, depth=None):
205205
def dispatch_rpc(service_name, method, params):
206206
""" Handle a RPC call.
207207
208-
This is pure Python code, the actual marshalling (from/to XML-RPC or
209-
NET-RPC) is done in a upper layer.
208+
This is pure Python code, the actual marshalling (from/to XML-RPC) is done
209+
in a upper layer.
210210
"""
211211
try:
212212
rpc_request = logging.getLogger(__name__ + '.rpc.request')

openerp/tools/config.py

+3-14
Original file line numberDiff line numberDiff line change
@@ -142,17 +142,6 @@ def __init__(self, fname=None):
142142
help="specify the private key file for the SSL connection")
143143
parser.add_option_group(group)
144144

145-
# NET-RPC
146-
group = optparse.OptionGroup(parser, "NET-RPC Configuration")
147-
group.add_option("--netrpc-interface", dest="netrpc_interface", my_default='',
148-
help="specify the TCP IP address for the NETRPC protocol")
149-
group.add_option("--netrpc-port", dest="netrpc_port", my_default=8070,
150-
help="specify the TCP port for the NETRPC protocol", type="int")
151-
# Needed a few day for runbot and saas
152-
group.add_option("--no-netrpc", dest="netrpc", action="store_false", my_default=False, help="disable the NETRPC protocol")
153-
group.add_option("--netrpc", dest="netrpc", action="store_true", my_default=False, help="enable the NETRPC protocol")
154-
parser.add_option_group(group)
155-
156145
# WEB
157146
# TODO move to web addons after MetaOption merge
158147
group = optparse.OptionGroup(parser, "Web interface Configuration")
@@ -383,8 +372,8 @@ def die(cond, msg):
383372
'db_name', 'db_user', 'db_password', 'db_host',
384373
'db_port', 'db_template', 'logfile', 'pidfile', 'smtp_port',
385374
'email_from', 'smtp_server', 'smtp_user', 'smtp_password',
386-
'netrpc_interface', 'netrpc_port', 'db_maxconn', 'import_partial', 'addons_path',
387-
'netrpc', 'xmlrpc', 'syslog', 'without_demo', 'timezone',
375+
'db_maxconn', 'import_partial', 'addons_path',
376+
'xmlrpc', 'syslog', 'without_demo', 'timezone',
388377
'xmlrpcs_interface', 'xmlrpcs_port', 'xmlrpcs',
389378
'static_http_enable', 'static_http_document_root', 'static_http_url_prefix',
390379
'secure_cert_file', 'secure_pkey_file', 'dbfilter', 'log_handler', 'log_level'
@@ -407,7 +396,7 @@ def die(cond, msg):
407396
keys = [
408397
'language', 'translate_out', 'translate_in', 'overwrite_existing_translations',
409398
'debug_mode', 'smtp_ssl', 'load_language',
410-
'stop_after_init', 'logrotate', 'without_demo', 'netrpc', 'xmlrpc', 'syslog',
399+
'stop_after_init', 'logrotate', 'without_demo', 'xmlrpc', 'syslog',
411400
'list_db', 'xmlrpcs', 'proxy_mode',
412401
'test_file', 'test_enable', 'test_commit', 'test_report_directory',
413402
'osv_memory_count_limit', 'osv_memory_age_limit', 'max_cron_threads', 'unaccent',

scripts/run_all_with_tests.sh

-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,5 @@ rm openerp-server.log
1212
--stop-after-init \
1313
--no-xmlrpc \
1414
--no-xmlrpcs \
15-
--no-netrpc \
1615
--test-enable \
1716
--logfile=openerp-server.log

0 commit comments

Comments
 (0)