We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's great that clustpy has type hints, but some of them are incorrect/outdated. Examples:
ClustPy/clustpy/data/real_torchvision_data.py
Lines 16 to 17 in b52d11a
(torch.Tensor, torch.Tensor)
tuple[torch.Tensor, torch.Tensor]
from collections.abc import Callable
typing.List
list
I'm sure there are others as well. Ideally, correctness would be verified with mypy or so but I realize that this is a lot of work.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
It's great that clustpy has type hints, but some of them are incorrect/outdated. Examples:
ClustPy/clustpy/data/real_torchvision_data.py
Lines 16 to 17 in b52d11a
(torch.Tensor, torch.Tensor)
is incorrect, it shout betuple[torch.Tensor, torch.Tensor]
Should be
from collections.abc import Callable
as you want to rely on built-ins as much as possible.typing.List
, uselist
instead.I'm sure there are others as well. Ideally, correctness would be verified with mypy or so but I realize that this is a lot of work.
The text was updated successfully, but these errors were encountered: