Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvement #868

Open
4 of 5 tasks
henrywang opened this issue Nov 5, 2024 · 1 comment
Open
4 of 5 tasks

Test improvement #868

henrywang opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
area/ci Issues related to our own CI

Comments

@henrywang
Copy link
Contributor

henrywang commented Nov 5, 2024

I went through all tests in this repo. We have unit test, integration test and end to end test. The tests running against each PR should be fast and stable. And test should be easy to make contribution. I have some thoughts on test:

  • Keep running unit test, it's fast and easy to make contribution. Enable code coverage?
  • end to end test can be removed because it takes long time to run and QE has a daily end to end test against latest main copr build.
  • Integration test should have all bootc commands and args included.
  • Now we have nushell and python for integration test. I like nushell a lot. But looks python is generic for test code.
  • TMT + Packit is good for Fedora and CentOS, but it does not support the other distros.

The reason I am opening this issue is to start a discussion about testing. Comments are welcome!

@cgwalters
Copy link
Collaborator

end to end test can be removed because it takes long time to run and QE has a daily end to end test against latest main copr build.

Yes, though I'd like to be able to opt-in to it for specific PRs; I think we can do that with a label trigger or a comment trigger.

Now we have nushell and python for integration test. I like nushell a lot. But looks python is generic for test code.

Yeah let's kill the python stuff.

TMT + Packit is good for Fedora and CentOS, but it does not support the other distros.

Yes, though for the most part just building across other distros/OSes is trivial in containers in GHA; the harder part is reference base images and builds.

@cgwalters cgwalters added the area/ci Issues related to our own CI label Nov 5, 2024
cgwalters added a commit to cgwalters/bootc that referenced this issue Nov 6, 2024
It's not useful to have two frameworks here, let's just use nushell.
ref containers#868

Signed-off-by: Colin Walters <[email protected]>
henrywang added a commit to henrywang/bootc that referenced this issue Dec 4, 2024
xref: containers#868

Signed-off-by: Xiaofeng Wang <[email protected]>
cgwalters pushed a commit to henrywang/bootc that referenced this issue Dec 4, 2024
xref: containers#868

Signed-off-by: Xiaofeng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues related to our own CI
Projects
None yet
Development

No branches or pull requests

2 participants