Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the args field from Container #225

Open
moshewe opened this issue Jun 23, 2021 · 2 comments
Open

Remove the args field from Container #225

moshewe opened this issue Jun 23, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@moshewe
Copy link
Contributor

moshewe commented Jun 23, 2021

Summary

According to the Argo documentation, container doesn't have an args field at all. It's used to put input parameters, with the input field used to put input artifacts (pulled in from the run_container method). It's counter-intuitive. I think a better solution would be to use the input field solely for the purpose of defining template inputs.

Use Cases

Better alignment with Argo docs, more intuitive code design and more fine grained container template definitions.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@moshewe moshewe added the enhancement New feature or request label Jun 23, 2021
@terrytangyuan
Copy link
Member

Would you like to propose changes that are backwards compatible and perhaps add a deprecation warning?

@moshewe
Copy link
Contributor Author

moshewe commented Jun 24, 2021

Deprecating it sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants