Skip to content

Commit

Permalink
Merge pull request hyperium#1303 from arthurprs/errorkind
Browse files Browse the repository at this point in the history
perf(http): prefer ErrorKind::WouldBlock
  • Loading branch information
seanmonstar authored Sep 8, 2017
2 parents 50fd4ab + 1e7e1c9 commit 7ba058a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/http/h1/encode.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ impl Chunked {
match *self {
Chunked::Init |
Chunked::End => Ok(msg.len()),
_ => Err(io::Error::new(io::ErrorKind::WouldBlock, "chunked incomplete"))
_ => Err(io::ErrorKind::WouldBlock.into())
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/http/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ impl<T: Write> Write for Buffered<T> {
fn write(&mut self, data: &[u8]) -> io::Result<usize> {
let n = self.write_buf.buffer(data);
if n == 0 {
Err(io::Error::from(io::ErrorKind::WouldBlock))
Err(io::ErrorKind::WouldBlock.into())
} else {
Ok(n)
}
Expand Down
4 changes: 2 additions & 2 deletions src/mock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl<T: Read> Read for AsyncIo<T> {
Err(err)
} else if self.bytes_until_block == 0 {
self.blocked = true;
Err(io::Error::new(io::ErrorKind::WouldBlock, "mock block"))
Err(io::ErrorKind::WouldBlock.into())
} else {
let n = cmp::min(self.bytes_until_block, buf.len());
let n = try!(self.inner.read(&mut buf[..n]));
Expand All @@ -122,7 +122,7 @@ impl<T: Write> Write for AsyncIo<T> {
if let Some(err) = self.error.take() {
Err(err)
} else if self.bytes_until_block == 0 {
Err(io::Error::new(io::ErrorKind::WouldBlock, "mock block"))
Err(io::ErrorKind::WouldBlock.into())
} else {
trace!("AsyncIo::write() block_in = {}, data.len() = {}", self.bytes_until_block, data.len());
self.flushed = false;
Expand Down

0 comments on commit 7ba058a

Please sign in to comment.