Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QE] test case for noproxy: whitespaces value #4411

Closed
lilyLuLiu opened this issue Oct 23, 2024 · 2 comments · Fixed by #4580
Closed

[QE] test case for noproxy: whitespaces value #4411

lilyLuLiu opened this issue Oct 23, 2024 · 2 comments · Fixed by #4580
Assignees
@rohanKanojia

Comments

@lilyLuLiu
Copy link
Contributor

https://redhat-internal.slack.com/archives/C032QG6EQE7/p1729260593118069?thread_ts=1729180230.862549&cid=C032QG6EQE7
@rohanKanojia rohanKanojia self-assigned this Jan 20, 2025
@rohanKanojia
Copy link
Contributor

rohanKanojia commented Jan 20, 2025 •
edited
Loading

@lilyLuLiu : Do we need to implement e2e test cases or unit test cases? I think for an issue like this unit tests can be easily implemented to cover various proxy cases.

rohanKanojia added a commit to rohankanojia-forks/crc that referenced this issue Jan 20, 2025
@rohanKanojia
test (validations) : Add some unit tests around proxy validation (crc…
0f0e086 
…-org#4411)

Add some unit tests to test various values provided to these validation methods:
- validateHTTPProxy
- validateHTTPSProxy
- validateNoProxy

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue Jan 20, 2025
Merged
12 tasks
@lilyLuLiu
Copy link
Contributor Author

@rohanKanojia , There is no need to add e2e test case on crc side. This failure is from the podman-desktop side that using invalid value of noproxy. An e2e test should be added on the podman-desktop side.

praveenkumar pushed a commit that referenced this issue Jan 23, 2025
@rohanKanojia @praveenkumar
test (validations) : Add some unit tests around proxy validation (#4411)
ab8cf0b 
Add some unit tests to test various values provided to these validation methods:
- validateHTTPProxy
- validateHTTPSProxy
- validateNoProxy

Signed-off-by: Rohan Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test (validations) : Add some unit tests around proxy validation (#4411) rohankanojia-forks/crc
2 participants
@rohanKanojia @lilyLuLiu