-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QE] fix e2e test failure of podman #4424
Comments
Can you point out the feature file for that? Also I think we want to use podman remote instead podman on system since it is not default available for mac/windows. |
Tests should be using podman-remote for win/mac and podman for linux |
@praveenkumar , This failure all happened on tests of Linux. |
@adrianriobo Does that mean for win/mac it is using podman socket which is running inside the crc VM or using podman-machine vm? |
Yeah, for win and mac any scenario making use of podman is relying on "our" podman (crc-VM) |
@adrianriobo so in this case we should also do same for linux right? |
Well, we are not making it for testing our podman setup, but b/c we rely on some container engine. In the end we somehow would like to test the interaction between podman / crc. I would suggest keep the same strategy, as in future we remove the podman socket or make more tricky to make use of it ..we may end on a situation where we need to use podman machine on win and mac and keep using podman on linux. dunno...WDYT? |
What we want to have our test case follow same steps on all platform to have reliable metrics in case of this https://github.com/crc-org/crc/blob/main/test/e2e/features/story_openshift.feature#L55-L66 (which is causing issue).
In this case I would suggest to have a different test case only for linux which use the podman installed on the system instead using podman-socket from the VM. |
Well the intention should be scenario spec should be the same the tech underneath implementing it is controlled by code (in this case use "our" podman socket for win and mac and podman for linux). And this is fine...what I do not know is why on Linux is not working as expected and it is complaining about the socket. And this should be target of this issue, know why and fix it |
From source: If we just call on purpose podman remote, should we avoid that on linux? crc/test/e2e/features/story_openshift.feature Lines 55 to 66 in 6652e57
|
It is because we have https://github.com/crc-org/crc/blob/main/test/extended/crc/cmd/cmd.go#L214C2-L217C44 logic so what I suspect that on linux since we are running |
Ohh my bad from top of my head I thought that should be using podman not podman-remote...about the That line goes to crc/test/e2e/testsuite/testsuite.go Line 942 in d9f83bc
|
After investigation, the |
Test case
Pull image locally, push to registry, deploy
sometimes failed:But this error never appear in nightly run. And I checked the machine, podman work well.
this is b/c somehow it is trying to use podman remote instead of podman.
The text was updated successfully, but these errors were encountered: