Don't assume default storage pool is at /var/lib/libvirt/images in crc_libvirt.sh and test1-worker-0-98nsr.xml

[bbrowning]

This script checks that the default storage pool exists and if it doesn't, it creates it at /var/lib/libvirt/images. However, later on in the script, it assumes that the default pool is set to this value. In my case, I already have a default pool but set to a location in my home directory which is a much larger partition than my root partition.

https://github.com/praveenkumar/osp4/blob/6f7d3ea9bf2ac194aceac4b3ae1be81d509c6615/libvirt/crc_libvirt.sh#L218 needs to have a dynamic path based on the location of the default storage pool.

I also have this problem in the tgz release I'm using in the file test1-worker-0-98nsr.xml <source file='/var/lib/libvirt/images/test1-worker-0-98nsr'/> but I don't see that file in source control to link to.

[gbraad]

the file is a `dumpxml` of the VM definition, You can get this with `virsh`

…

On Fri, Jan 18, 2019 at 10:21 PM Ben Browning ***@***.***> wrote: This script checks that the default storage pool exists and if it doesn't, it creates it at /var/lib/libvirt/images. However, later on in the script, it assumes that the default pool is set to this value. In my case, I already have a default pool but set to a location in my home directory which is a much larger partition than my root partition. https://github.com/praveenkumar/osp4/blob/6f7d3ea9bf2ac194aceac4b3ae1be81d509c6615/libvirt/crc_libvirt.sh#L218 needs to have a dynamic path based on the location of the default storage pool. I also have this problem in the tgz release I'm using in the file test1-worker-0-98nsr.xml <source file='/var/lib/libvirt/images/test1-worker-0-98nsr'/> but I don't see that file in source control to link to. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/praveenkumar/osp4/issues/20>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAHZowBmHm4bA52t-W3_K_jWX6AiQF6ks5vEdhrgaJpZM4aH_lL> .

-- Gerard Braad | http://gbraad.nl [ Doing Open Source Matters ]